You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-06] [$1000] Web - Pressing ESC on attachment preview glitches the preview #27237
Click on ESC multiple times, observe that preview closes, reopens with different image and closes
Expected Result:
App should close preview on ESC click (note you need to press Esc multiple times)
Actual Result:
App glitches on closing preview on ESC click
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.61-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Web - Pressing ESC on attachment preview glitches the preview[/-][+][$500] Web - Pressing ESC on attachment preview glitches the preview[/+]on Sep 12, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Not a regression.
Determine if we should create a regression test for this bug.
Yes.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Hi @Christinadobrzyn, sorry for the delay, the job was actually raised after 30 August but you have sent me 250$ offer, can you rectify it once to 50$?
Activity
melvin-bot commentedon Sep 12, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]Web - Pressing ESC on attachment preview glitches the preview[/-][+][$500] Web - Pressing ESC on attachment preview glitches the preview[/+]melvin-bot commentedon Sep 12, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ebd6c095f0ad277c
melvin-bot commentedon Sep 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 12, 2023
Triggered auto assignment to @adelekennedy (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 12, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)ishpaul777 commentedon Sep 12, 2023
zukilover commentedon Sep 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App glitches on closing preview on ESC click
What is the root cause of that problem?
AttachmentModalis using unnecessaryuseCallbackforcloseModalfunction. This causes React to not throw away the cached function.App/src/components/AttachmentModal.js
Lines 307 to 309 in 5f668c6
What changes do you think we should make in order to solve the problem?
Remove the
useCallbackwrapper forcloseModal, e.g.:This is the safest and optimal way since the modal visibility is controlled by a local state.
What alternative solutions did you explore? (Optional)
N/A
164 remaining items
melvin-bot commentedon Nov 29, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Dec 6, 2023
prepping for payment
Payouts due:
Issue Reporter: $50 @dhanashree-sawant (PAID in Upwork)
Contributor: $750 @paultsimura (PAID in Upwork) & $250 @tsa321 (PAID in Upwork)
Contributor+: $1000 @abdulrahuman5196 (PAID in Upwork)
Eligible for 50% #urgency bonus? N
Upwork job is here.
@abdulrahuman5196 do we need a regression for this?
paultsimura commentedon Dec 6, 2023
Thank you @Christinadobrzyn
Based on this comment: #27237 (comment), could you please split my bounty into $750 for me, and $250 for @tsa321?
abdulrahuman5196 commentedon Dec 6, 2023
Not a regression.
Yes.
@Christinadobrzyn
Christinadobrzyn commentedon Dec 8, 2023
Awesome! Thanks @abdulrahuman5196!
I paid you and @paultsimura in Upwork based on this payment structure #27237 (comment)
@tsa321 and @dhanashree-sawant can you accept the Upwork offer and I'll pay you?
dhanashree-sawant commentedon Dec 8, 2023
Hi @Christinadobrzyn, sorry for the delay, the job was actually raised after 30 August but you have sent me 250$ offer, can you rectify it once to 50$?
tsa321 commentedon Dec 8, 2023
@Christinadobrzyn I have accepted the offers, thank you...
Christinadobrzyn commentedon Dec 9, 2023
Thanks @tsa321! I paid you in Upwork based on this payment summary.
Thanks for catching that @dhanashree-sawant - I got my dates mixed up - I sent you a modified offer, would you mind accepting so I can pay you?
dhanashree-sawant commentedon Dec 9, 2023
That's fine, I have accepted the offer.
Christinadobrzyn commentedon Dec 9, 2023
Thanks @dhanashree-sawant! I paid you in Upwork based on our payment summary.
This is good to close - thanks everyone!