[HOLD for payment 2023-10-18] [$1000] Desktop - RBR - Deleted error notifications reappear after reloading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Preconditions:
PDF for the test https://drive.google.com/file/d/1iOhC-C5CFh6x0W_a5ByTbKX8vW6tLTGW/view?usp=sharing

Open a New Expensify app
Log in with any account
Navigate to any report
Add a corrupted PDF file as an attachment using the link.
Remove the error notification that appears.
Refresh the application (CMD+R) or page

Expected Result:

Deleted error notifications should not reappear after a page refresh or reloading the app

Actual Result:

Deleted error notifications reappear after refreshing the page or reloading the app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.68-15

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6198416_Recording__267.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0109ee3a6201dbf246
Upwork Job ID: 1702260302620733440
Last Price Increase: 2023-10-02
Automatic offers:

situchan | Reviewer | 27017995
shubham1206agra | Contributor | 27017996

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~0109ee3a6201dbf246

@bfitzexpensify

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

@situchan

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop, Web, iOS (Safari/Chrome), Android/Chrome - RBR - Deleted error notifications reappear after reloading

What is the root cause of that problem?

The root cause of this problem appears to be related to how the clearReportActionErrors function handles the deletion of error notifications and the associated report actions. The existing code may not correctly update the state or store data, leading to the reappearance of error notifications upon reloading the application. This issue is specifically observed in the src/libs/actions/ReportActions.js file.

What changes do you think we should make in order to solve the problem?

To address the issue of deleted error notifications reappearing after reloading in the Desktop application, I propose the following changes to the clearReportActionErrors function:

src/libs/actions/ReportActions.js

Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, {
 [reportAction.reportActionID]: false,
});

This code snippet effectively replaces null with false to remove the association of the error with the report action, ensuring that deleted error notifications do not reappear after a reload.

Please review and let me know if any further information or changes are needed.

@programmerkenzi

📣 @programmerkenzi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email: contact@kenzichen.com
Upwork Profile Link: https://www.upwork.com/fl/kenzichen

Reviewing label has been removed, please complete the "BugZero Checklist".

@shubham1206agra

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: RBR - Deleted error notifications reappear after reloading #28810

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@shubham1206agra requires payment offer (Contributor)
@situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@shubham1206agra

Payment summary:

Contributor: @shubham1206agra is owed $1500 for work completed and urgency bonus - paid via Upwork ✅
C+: @situchan is owed $1500 for work completed and urgency bonus - paid via Upwork ✅

@situchan

@situchan a reminder to complete the BZ checklist when you get a moment - thanks!

I think bug existed for long time but just not caught earlier as edge case.
Also this was caught by Applause team, no need another regression test.

Cool, agreed. We're all done here then, closing this one out - thanks everyone!

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-18] [$1000] Desktop - RBR - Deleted error notifications reappear after reloading #27315

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

50 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-10-18] [$1000] Desktop - RBR - Deleted error notifications reappear after reloading #27315

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 13, 2023

melvin-bot commented on Sep 13, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Sep 14, 2023

melvin-bot commented on Sep 14, 2023

melvin-bot commented on Sep 14, 2023

programmerkenzi commented on Sep 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Sep 15, 2023

programmerkenzi commented on Sep 15, 2023

50 remaining items

melvin-bot commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

bfitzexpensify commented on Oct 18, 2023

bfitzexpensify commented on Oct 18, 2023

situchan commented on Oct 18, 2023

bfitzexpensify commented on Oct 19, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions