You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Workspace - Company type dropdown in Adding bank account page (Step 2) is broken #27334
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Activity
OSBotify commentedon Sep 13, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 13, 2023
Triggered auto assignment to @srikarparsi (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.ishpaul777 commentedon Sep 13, 2023
Proposal
Problem
Company type dropdown in Adding bank account page (Step 2) is broken
Root cause
we are mapping a translation key which is a string to picker items.
Changes
Create a array with incorporation types in constants, map the array to items like below, in Companystep
dummy-1111 commentedon Sep 13, 2023
This is a regression of this PR
getusha commentedon Sep 13, 2023
Dupe of #27326
AndrewGable commentedon Sep 13, 2023
Looks like this is going to be fixed by #27358
srikarparsi commentedon Sep 18, 2023
Closing this one out since it's fixed here