Skip to content

[Wave 6: Categories] Category/Tag Selector Show up in DM Money Requests #27556

Closed

Description

@yuwenmemon

Action Performed:

  1. Create a new account
  2. Create a money request from another user
  3. On the confirmation step, observe that the category and tag selectors show for the money request:
    https://github.com/Expensify/App/assets/4741899/16a59421-b77a-42da-a35b-0a0e49d25822

Expected Result:

  • The Category and Tag selectors should not show for a DM Money Request because that chat report does not belong to a policy (They belong to the policy _FAKE_)

Actual Result:

  • The Category/Tag selector is visible for the Money Request on the confirmation page.

Workaround:

  • This feature is under a beta so real-life users can't see it yet.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: N/A
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL: N/A
Issue reported by: @rezkiy37
Slack conversation: https://expensify.slack.com/archives/C02MW39LT9N/p1694793499639819

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019f9ca0cd0d1a9a22
  • Upwork Job ID: 1702759634044727296
  • Last Price Increase: 2023-09-15
  • Automatic offers:
    • situchan | Reviewer | 26699580

Activity

  1. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  2. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 15, 2023
  4. changed the title [-]Category/Tag Selector Show up in DM Money Requests[/-] [+][$500] Category/Tag Selector Show up in DM Money Requests[/+] on Sep 15, 2023
  5. melvin-bot commented on Sep 15, 2023

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 15, 2023
  7. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

  8. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 15, 2023
  10. 13 remaining items

  11. rezkiy37 commented on Sep 21, 2023

    @rezkiy37
    Contributor

    The PR - #27459 - has been merged.

  12. puneetlath commented on Sep 22, 2023

    @puneetlath
    Contributor

    @situchan I see you assigned to the issue, but it doesn't look like you were involved in the PR review, is that correct?

  13. situchan commented on Sep 22, 2023

    @situchan
    Contributor

    @situchan I see you assigned to the issue, but it doesn't look like you were involved in the PR review, is that correct?

    correct. I wasn't aware that linked PR was in progress.
    Seems like #27459 wasn't reviewed by any C+.

    @rezkiy37 in the future, please link issues like this so that automation would work correctly

    Wrong:

    $ https://github.com/Expensify/App/issues/24464, https://github.com/Expensify/App/issues/27556
    

    Correct:

    $ https://github.com/Expensify/App/issues/24464
    $ https://github.com/Expensify/App/issues/27556
    
  14. puneetlath commented on Sep 22, 2023

    @puneetlath
    Contributor

    Ok, thanks for confirming @situchan. We're good to close this out in that case once the PR is deployed to production.

  15. changed the title [-][$500] Category/Tag Selector Show up in DM Money Requests[/-] [+][Wave 6: Categories] Category/Tag Selector Show up in DM Money Requests[/+] on Sep 22, 2023
  16. rezkiy37 commented on Sep 22, 2023

    @rezkiy37
    Contributor

    @situchan I see you assigned to the issue, but it doesn't look like you were involved in the PR review, is that correct?

    correct. I wasn't aware that linked PR was in progress. Seems like #27459 wasn't reviewed by any C+.

    @rezkiy37 in the future, please link issues like this so that automation would work correctly

    Wrong:

    $ https://github.com/Expensify/App/issues/24464, https://github.com/Expensify/App/issues/27556
    

    Correct:

    $ https://github.com/Expensify/App/issues/24464
    $ https://github.com/Expensify/App/issues/27556
    

    Sorry, my bad 😅

  17. rezkiy37 commented on Sep 26, 2023

    @rezkiy37
    Contributor

    The issue (#24464), in which scope I fixed the bug, already closed.

  18. puneetlath commented on Sep 27, 2023

    @puneetlath
    Contributor

    @rezkiy37 just to clarify, you're saying this bug has been fixed and we can close this issue, is that correct?

  19. rezkiy37 commented on Sep 27, 2023

    @rezkiy37
    Contributor

    @rezkiy37 just to clarify, you're saying this bug has been fixed and we can close this issue, is that correct?

    Yes, it is correct.

  20. puneetlath commented on Sep 27, 2023

    @puneetlath
    Contributor

    Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions