Repository navigation
[HOLD for payment 2023-10-02] [$500] Dev: Web - Linear Gradient on Lounge Access Page header is broken #27600
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Action Performed:
- Make sure you have access to lounge access page.
- Navigate to Lounge Access Page.
Expected Result:
Header Animation should have a animation overlay
Actual Result:
Header Animation don't have a animation overlay
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: Dev 1.3.70.5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694797951259709
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d60a245e73bb23c0
- Upwork Job ID: 1703133462496907264
- Last Price Increase: 2023-09-16
Activity
[-]Dev: Web - Linear Gradient on Lounge Access Page header is broken[/-][+][$500] Dev: Web - Linear Gradient on Lounge Access Page header is broken[/+]melvin-bot commentedon Sep 16, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01d60a245e73bb23c0
melvin-bot commentedon Sep 16, 2023
Triggered auto assignment to @bfitzexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 16, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)ishpaul777 commentedon Sep 16, 2023
Proposal
Problem
Linear Gradient on Lounge Access Page header is broken
Root cause
themeColors.darkColor used in in gradient is undefined.https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/LoungeAccessPage.js#L69
Changes
we need to use color
colors.blue800instead ofthemeColors.darkwhich is not defined, we can define a new variableloungeAccessOverlayin default.js and light.js withcolors.blue800Demo
Pujan92 commentedon Sep 18, 2023
@grgia This seems to persist after theme PR gets merged as
darkvariable removed from thecolors.jsfile.grgia commentedon Sep 18, 2023
I'll take this internally in that case. @Pujan92
melvin-bot commentedon Sep 18, 2023
Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.
4 remaining items
[-][$500] Dev: Web - Linear Gradient on Lounge Access Page header is broken[/-][+][HOLD for payment 2023-10-02] [$500] Dev: Web - Linear Gradient on Lounge Access Page header is broken[/+]melvin-bot commentedon Sep 25, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
bfitzexpensify commentedon Oct 2, 2023
Payment summary:
Payment for @thesahindia for internal PR review - $500.
No other payment required. Closing this one out.
ishpaul777 commentedon Oct 2, 2023
Hii @bfitzexpensify, Can you please clarify why is this not eligible for reporting bonus?
bfitzexpensify commentedon Oct 2, 2023
Hey @ishpaul777, it is definitely eligible - I missed your mention in the OP, sorry about that. I've just sent an offer to you via Upwork.
ishpaul777 commentedon Oct 3, 2023
@bfitzexpensify Thanks for sending the offer! Accepted!
bfitzexpensify commentedon Oct 3, 2023
Paid out, so we're all done here
ishpaul777 commentedon Oct 3, 2023
Thanks! Payment Recieved.
JmillsExpensify commentedon Oct 25, 2023
$500 payment approved for @thesahindia based on BZ summary.