[HOLD for payment 2023-10-02] [$500] Web - Private Notes - Header is blur while the page is loading.

@hungvu193

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to any report.
Click on the Report Details => Private Notes.
Verify that the Header is blur while the page is loading.

Expected Result:

The header should be clearly visible while the page is loading

Actual Result:

he header is blur while the page is loading.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-17.at.09.52.42.mov

Recording.4568.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694919130569099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fa74e845c90b0078
Upwork Job ID: 1703786341303091200
Last Price Increase: 2023-09-18
Automatic offers:

jjcoffee | Reviewer | 26790081
hungvu193 | Contributor | 26790083
hungvu193 | Reporter | 26790085

@adelekennedy

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~01fa74e845c90b0078

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@anmurali

Triggered auto assignment to @anmurali (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@jjcoffee

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@hungvu193

Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694919130569099

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private Notes - Header is blur while the page is loading which make it inconsistency with other pages that have loading.

What is the root cause of that problem?

We're using FullScreenLoadingIndicator while the page is loading here, since it use StyleSheet.absoluteFillObject which caused the issue.

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 131 to 133 in c77814f

    
           {report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? ( 
        
               <FullScreenLoadingIndicator /> 
        
           ) : (

What changes do you think we should make in order to solve the problem?

We should add style style={[styles.flex1, styles.pRelative]} for our FullScreenLoadingIndicator.

What alternative solutions did you explore? (Optional)

Incase we didn't want to show the header while loading, we can make FullScreenLoadingIndicator as a return early:

if (report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {}))) {
  return  <FullScreenLoadingIndicator />;
}

return (
....
);

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private Notes - Header is blur while the page is loading

What is the root cause of that problem?

We are using <FullScreenLoadingIndicator /> while the Private Notes page is loading, and it's styling is causing delays in rendering the header ie. StyleSheet.absoluteFillObject

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 131 to 135 in 6be8fca

    
           {report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? ( 
        
               <FullScreenLoadingIndicator /> 
        
           ) : ( 
        
               _.map(privateNotes, (item, index) => getMenuItem(item, index)) 
        
           )}

What changes do you think we should make in order to solve the problem?

We need to remove StyleSheet.absoluteFillObject and add styles.flex1 here:

App/src/components/FullscreenLoadingIndicator.js

Line 20 in 6be8fca

    
           <View style={[StyleSheet.absoluteFillObject, styles.fullScreenLoading, ...additionalStyles]}>

What alternative solutions did you explore? (Optional)

NA

Result:

Screen.Recording.2023-09-18.at.10.27.28.PM.mov

Everyone's been paid.

@Li357

@Li357, @anmurali, @hungvu193, @jjcoffee Huh... This is 4 days overdue. Who can take care of this?

The PR that introduced the bug has been identified. Link to the PR: N/A behaviour has always been there.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A should've been caught in QA
Determine if we should create a regression test for this bug. No - I don't think it's worthwhile (it could happen on any screen really)
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

@anmurali

@anmurali Checklist complete, you're welcome to close!

@Li357

@Li357, @anmurali, @hungvu193, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Li357

@Li357, @anmurali, @hungvu193, @jjcoffee 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Closing!

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-02] [$500] Web - Private Notes - Header is blur while the page is loading. #27685

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result:

26 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? (
	<FullScreenLoadingIndicator />
	) : (

[HOLD for payment 2023-10-02] [$500] Web - Private Notes - Header is blur while the page is loading. #27685

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 18, 2023

melvin-bot commented on Sep 18, 2023

melvin-bot commented on Sep 18, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Sep 18, 2023

melvin-bot commented on Sep 18, 2023

kbecciv commented on Sep 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

PiyushChandra17 commented on Sep 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result:

26 remaining items

anmurali commented on Oct 4, 2023

melvin-bot commented on Oct 9, 2023

jjcoffee commented on Oct 9, 2023

jjcoffee commented on Oct 9, 2023

melvin-bot commented on Oct 13, 2023

melvin-bot commented on Oct 17, 2023

Li357 commented on Oct 17, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions