You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Web - Private Note - Input is not focused after reloading the page. #27695
Go to any Report => Report Details => Private Notes.
Click My Notes => Reload the page.
Notice that the Input is not focused.
Expected Result:
Input should be focused after reloading the page.
Actual Result:
Input is not focused after reloading the page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.71.4 Reproducible in staging?: y Reproducible in production?: new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
What changes do you think we should make in order to solve the problem?
We should use useFocusEffect and InteractionManager.runAfterInteractions in the same way we operate in EditRequestAmountPage to make the input is always focused when the page is focused.
changed the title [-]Web - Private Note - Input is not focused after reloading the page.[/-][+][$500] Web - Private Note - Input is not focused after reloading the page.[/+]on Sep 18, 2023
Please re-state the problem that we are trying to solve in this issue.
Private Note - Input is not focused after reloading the page.
What is the root cause of that problem?
We're focusing the input after transition end, however while the page is reloading, privateNotesInput.current will be null first focusAndUpdateMultilineInputRange will early return.
@Ollyws@kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
dukenv0307 commentedon Sep 18, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Dev: Web - Private notes - Delay in displaying the "Notes" field and "Save" button when refreshing the Private
What is the root cause of that problem?
We focus the input when the
onEntryTransitionEndis triggered. But when we reload the page, sometimes this is not triggered.App/src/pages/PrivateNotes/PrivateNotesEditPage.js
Line 81 in c77814f
What changes do you think we should make in order to solve the problem?
We should use
useFocusEffectandInteractionManager.runAfterInteractionsin the same way we operate inEditRequestAmountPageto make the input is always focused when the page is focused.What alternative solutions did you explore? (Optional)
NA
Result
Screencast.from.17-09-2023.21.17.33.webm
melvin-bot commentedon Sep 18, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 18, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 18, 2023
Job added to Upwork: https://www.upwork.com/jobs/~012866eed98442daeb
[-]Web - Private Note - Input is not focused after reloading the page.[/-][+][$500] Web - Private Note - Input is not focused after reloading the page.[/+]melvin-bot commentedon Sep 18, 2023
Triggered auto assignment to @jliexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 18, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)kbecciv commentedon Sep 18, 2023
Proposal by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694924854779879
Proposal
Please re-state the problem that we are trying to solve in this issue.
Private Note - Input is not focused after reloading the page.
What is the root cause of that problem?
We're focusing the input after transition end, however while the page is reloading,
privateNotesInput.currentwill be null firstfocusAndUpdateMultilineInputRangewill early return.App/src/pages/PrivateNotes/PrivateNotesEditPage.js
Line 81 in c77814f
What changes do you think we should make in order to solve the problem?
Incase
privateNotesInputis set yet and screen did end transition, we should focus the Input. So we should update the TextInput's ref as below:What alternative solutions did you explore? (Optional)
N/A
7 remaining items
kadiealexander commentedon Sep 22, 2023
@Ollyws could you please take a look at the proposals above?
kadiealexander commentedon Sep 25, 2023
Bumped in Slack!
Ollyws commentedon Sep 25, 2023
Seems like this was already fixed by #27702
hungvu193 commentedon Sep 25, 2023
Agree. I couldn't reproduce as well
melvin-bot commentedon Sep 25, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Ollyws commentedon Sep 27, 2023
@kadiealexander We're good to close this one as it's already been fixed, thanks.
melvin-bot commentedon Oct 2, 2023
@Ollyws @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Oct 2, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Oct 3, 2023
@Ollyws, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?