Skip to content

[HOLD for payment 2023-09-29] FAB – STW button exists in the FAB menu #27707

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #27479

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with any account
  3. Open the FAB menu

Expected Result:

he STW button is not the FAB menu

Actual Result:

The STW button exists in the FAB menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.71-5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6205235_Web-Remove_the_STW_button.mp4
Bug6205235_Remove_the_STW_button.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 18, 2023
  2. melvin-bot commented on Sep 18, 2023

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 18, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. Christinadobrzyn commented on Sep 18, 2023

    @Christinadobrzyn
    Contributor

    Hey @marcochavezf @grgia and @youssef-lr - we have this PR - #27479

    Are we expecting something different than what is happening in this GH?

  5. youssef-lr commented on Sep 19, 2023

    @youssef-lr
    Contributor

    @marcochavezf seems like this is still an issue on staging?

  6. marcochavezf commented on Sep 19, 2023

    @marcochavezf
    Contributor

    This is weird, it was removed but still exists in main here 🤔

    I suppose it was brought back in a merge conflict in a recent PR. I will create another PR to remove it again

  7. marcochavezf commented on Sep 19, 2023

    @marcochavezf
    Contributor

    PR up

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 22, 2023
  9. changed the title [-]FAB – STW button exists in the FAB menu[/-] [+][HOLD for payment 2023-09-29] FAB – STW button exists in the FAB menu[/+] on Sep 22, 2023
  10. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-29. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [] The PR that introduced the bug has been identified. Link to the PR:
    • [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [] Determine if we should create a regression test for this bug.
    • [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. Christinadobrzyn commented on Sep 29, 2023

    @Christinadobrzyn
    Contributor

    Ready for payment, is there a regression test on this? I don't think so...

    I see @parasharrajat on the PR, are we paying you out for this? if yes, how much?

  14. melvin-bot commented on Oct 3, 2023

    @melvin-bot

    @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. Christinadobrzyn commented on Oct 3, 2023

    @Christinadobrzyn
    Contributor

    Payment info I'm not sure if this needs to be paid. I think this is a regression and it is being fixed by the original team. So I don't think payments are needed here.

    @youssef-lr or @marcochavezf could you confirm?

  16. parasharrajat commented on Oct 5, 2023

    @parasharrajat
    Member

    @Christinadobrzyn No payments for me here. it was a small change.

  17. Christinadobrzyn commented on Oct 5, 2023

    @Christinadobrzyn
    Contributor

    Thank you @parasharrajat - closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions