You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-29] FAB – STW button exists in the FAB menu #27707
changed the title [-]FAB – STW button exists in the FAB menu[/-][+][HOLD for payment 2023-09-29] FAB – STW button exists in the FAB menu[/+]on Sep 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[] The PR that introduced the bug has been identified. Link to the PR:
[] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[] Determine if we should create a regression test for this bug.
[] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payment info I'm not sure if this needs to be paid. I think this is a regression and it is being fixed by the original team. So I don't think payments are needed here.
Activity
melvin-bot commentedon Sep 18, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 18, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Christinadobrzyn commentedon Sep 18, 2023
Hey @marcochavezf @grgia and @youssef-lr - we have this PR - #27479
Are we expecting something different than what is happening in this GH?
youssef-lr commentedon Sep 19, 2023
@marcochavezf seems like this is still an issue on staging?
marcochavezf commentedon Sep 19, 2023
This is weird, it was removed but still exists in main here 🤔
I suppose it was brought back in a merge conflict in a recent PR. I will create another PR to remove it again
marcochavezf commentedon Sep 19, 2023
PR up
[-]FAB – STW button exists in the FAB menu[/-][+][HOLD for payment 2023-09-29] FAB – STW button exists in the FAB menu[/+]melvin-bot commentedon Sep 22, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Sep 29, 2023
Ready for payment, is there a regression test on this? I don't think so...
I see @parasharrajat on the PR, are we paying you out for this? if yes, how much?
melvin-bot commentedon Oct 3, 2023
@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Christinadobrzyn commentedon Oct 3, 2023
Payment info I'm not sure if this needs to be paid. I think this is a regression and it is being fixed by the original team. So I don't think payments are needed here.
@youssef-lr or @marcochavezf could you confirm?
parasharrajat commentedon Oct 5, 2023
@Christinadobrzyn No payments for me here. it was a small change.
Christinadobrzyn commentedon Oct 5, 2023
Thank you @parasharrajat - closing!