You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive #27774
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
As you can see in the above code segment, we didn't add the onAddToSelection props to the OptionsSelector component.
We need to add this props.
It would look like
changed the title [-][$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive[/-][+][HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive[/+]on Sep 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@parasharrajatdoes not require payment (Eligible for Manual Requests)
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Reporter: NA Applause Contributor:@situchan NA regression Upwork Contributor+:@parasharrajat NA regression Request
I'm not sure I've seen a deploy blocker fixed by the person that caused the regression - Curious is these amounts look correct to everyone. CC @mallenexpensify for a BZ buddy check
changed the title [-][HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive[/-][+][HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive[/+]on Sep 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@parasharrajatdoes not require payment (Eligible for Manual Requests)
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 19, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to @cristipaval (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.dummy-1111 commentedon Sep 19, 2023
This is a regression of this PR
App/src/components/MoneyRequestConfirmationList.js
Lines 423 to 439 in 778f763
As you can see in the above code segment, we didn't add the
onAddToSelectionprops to theOptionsSelectorcomponent.We need to add this props.
It would look like
dummy-1111 commentedon Sep 19, 2023
I think @MaciejSWM can fix this in no time
21 remaining items
[-][$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive[/-][+][HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive[/+]melvin-bot commentedon Sep 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 20, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
MitchExpensify commentedon Sep 21, 2023
Payment summary:
Reporter: NA Applause
Contributor: @situchan NA regression Upwork
Contributor+: @parasharrajat NA regression Request
I'm not sure I've seen a deploy blocker fixed by the person that caused the regression - Curious is these amounts look correct to everyone. CC @mallenexpensify for a BZ buddy check
situchan commentedon Sep 21, 2023
Not eligible for compensation if regression.
Btw, this is edge case. Due to urgency and to avoid more conflicts, we merged big PR as is though it isn't perfect and several issues remaining to be resolved. So it was expected to have some regressions and fix as follow-up.
Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1694772395119489?thread_ts=1694746421.663479&cid=C01GTK53T8Q
[-][HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive[/-][+][HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive[/+]melvin-bot commentedon Sep 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
parasharrajat commentedon Sep 26, 2023
This seems to be a regression from some PR. @situchan Could you please add the link to the PR?
No payments. We are good to close this @MitchExpensify
situchan commentedon Sep 26, 2023
#25564
cristipaval commentedon Sep 26, 2023
Thank you @parasharrajat and @situchan!