You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[DISTANCE] [$1000] LOW: mWeb / Safari- i icon and mapbox logo not displayed #27800
@lanitochka17 for those of us less familiar with this new feature, can you please provide a video example of the incorrect behavior, as well as a video example of the correct behavior? I'd like to see the difference between what you spotted on Safari vs Chrome.
This seems to be caused by the Smart App banner pushing down the elements, which can only be seen on the staging or production URLs. Still trying to figure out why.
There's an open PR that fixes a bug that occurs when the map container resizes. I am not sure if that would fix this, but it may be worth a shot to check it out.
After doing some more digging, it turns out that when the Smart App Banner is displayed, it somehow messes up the z-indexes of the map and its controls, since it triggers a re-render of the map canvas, and the map ends up being rendered over the Mapbox logo and the toggle attribution icon, resulting in the controls being hidden.
Setting a z-index of -1 for the .mapboxgl-canvas CSS class seems to solve the rendering problem. However, this prevents the map from being interacted with (tap / touch / pan / zoom operations stop working).
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Not a regression. Issue present as part of the mapbox implementation.
Determine if we should create a regression test for this bug.
Yes.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Open NewExpensify on Safari mWeb
Open Request Money page from global navigation
Open 'Distance' tab
Wait for the map to load
Verify that the MapBox logo and the information icon is shown at the bottom edge of the map
@johncschuster
Seems melvin bot didn't update here automatically. Seems the issue is in payment due for today - #30673 (comment)
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)johncschuster commentedon Sep 19, 2023
@lanitochka17 for those of us less familiar with this new feature, can you please provide a video example of the incorrect behavior, as well as a video example of the correct behavior? I'd like to see the difference between what you spotted on Safari vs Chrome.
Thanks!
m-natarajan commentedon Sep 19, 2023
@johncschuster I am attaching the video for reference.
RPReplay-Final1695160118.MP4
akinwale commentedon Sep 20, 2023
This seems to be caused by the Smart App banner pushing down the elements, which can only be seen on the staging or production URLs. Still trying to figure out why.
There's an open PR that fixes a bug that occurs when the map container resizes. I am not sure if that would fix this, but it may be worth a shot to check it out.
EDIT: The PR is in staging now, but no dice.
akinwale commentedon Sep 20, 2023
After doing some more digging, it turns out that when the Smart App Banner is displayed, it somehow messes up the z-indexes of the map and its controls, since it triggers a re-render of the map canvas, and the map ends up being rendered over the Mapbox logo and the toggle attribution icon, resulting in the controls being hidden.
Setting a
z-indexof-1for the.mapboxgl-canvasCSS class seems to solve the rendering problem. However, this prevents the map from being interacted with (tap / touch / pan / zoom operations stop working).melvin-bot commentedon Sep 25, 2023
@johncschuster, @lanitochka17 Huh... This is 4 days overdue. Who can take care of this?
johncschuster commentedon Sep 26, 2023
Thanks for posting that video, @m-natarajan! That was very helpful!
88 remaining items
abdulrahuman5196 commentedon Nov 17, 2023
Not a regression. Issue present as part of the mapbox implementation.
Yes.
@johncschuster
Seems melvin bot didn't update here automatically. Seems the issue is in payment due for today - #30673 (comment)
abdulrahuman5196 commentedon Nov 22, 2023
@johncschuster Gentle ping on payment as mentioned above.
aswin-s commentedon Nov 28, 2023
@johncschuster @dylanexpensify Gentle reminder on the payment.
johncschuster commentedon Nov 30, 2023
Thanks for the bump! I'll get payment issued shortly!
aswin-s commentedon Dec 9, 2023
Bump @johncschuster
johncschuster commentedon Dec 12, 2023
Sorry team! I let this slip. Payment has now been issued!
johncschuster commentedon Dec 12, 2023
I'll leave this open for me so I can get the regression steps
melvin-bot commentedon Dec 18, 2023
This issue has not been updated in over 15 days. @johncschuster, @aswin-s, @abdulrahuman5196, @lanitochka17, @aldo-expensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!