Repository navigation
[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-02] Android - Private notes - Code block creates empty lines below it in the note preview #27802
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to staging.new.expensify.com
- Go to any chat > chat header > Private note > My note
- Create multiple lines
- Add a code block markdown in the middle
- Save it
Expected Result:
The code block does not create empty lines below it in the note preview
Actual Result:
The code block creates empty lines below it in the note preview
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.71-7
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6206528_Screen_Recording_20230919_222620_New_Expensify.mp4
0-02-01-b002e7bf30b06646fe951cc3c6e9ea782b7f312c3cc0a9192f0e789380b564a8_1a4e6439066181b6.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 19, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to @jasperhuangg (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.jeet-dhandha commentedon Sep 19, 2023
Being Fixed here:
maddylewis commentedon Sep 20, 2023
@jasperhuangg - i don't think any BZ action is required, but lmk if you need me to do something for this one!
37 remaining items
[-][HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-02] Android - Private notes - Code block creates empty lines below it in the note preview[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-02] Android - Private notes - Code block creates empty lines below it in the note preview[/+]melvin-bot commentedon Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-02] Android - Private notes - Code block creates empty lines below it in the note preview[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-02] Android - Private notes - Code block creates empty lines below it in the note preview[/+]melvin-bot commentedon Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
maddylewis commentedon Oct 25, 2023
@jasperhuangg - is this fixed? can i close?
or, wait, is there a C+ that needs payment issued for this one?
jasperhuangg commentedon Oct 25, 2023
It looks like @jeet-dhandha submitted a PR, and @burczu was the reviewer.
I'm not sure if they've been paid out yet.