Skip to content

[HOLD for payment 2023-10-10] [$500] Dev: Web - Delete task message text color change in offline mode #27804

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Click on + icon and select assign task
  3. Enter title and create task
  4. Go to task thread and delete the task
  5. Go to parent report screen
  6. Go offline

Expected Result:

Delete task message text color should not change

Actual Result:

Delete task message text color changes to gray

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev 1.3.71-5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-19.at.11.53.07.AM.1.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695104920660599

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014b184e9e64be3573
  • Upwork Job ID: 1704196739021500416
  • Last Price Increase: 2023-09-19
  • Automatic offers:
    • dukenv0307 | Contributor | 26887595

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 19, 2023
  2. changed the title [-]Dev: Web - Delete task message text color change in offline mode[/-] [+][$500] Dev: Web - Delete task message text color change in offline mode[/+] on Sep 19, 2023
  3. melvin-bot commented on Sep 19, 2023

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 19, 2023
  5. melvin-bot commented on Sep 19, 2023

    @melvin-bot

    Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  6. melvin-bot commented on Sep 19, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

  7. ZhenjaHorbach commented on Sep 19, 2023

    @ZhenjaHorbach
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue

    Delete task item color should not change

    What is the root cause of that problem?

    We don't have the conditions for this

    What changes do you think we should make in order to solve the problem?

    We can update this line like

    pendingAction={props.draftMessage || ReportUtils.isCanceledTaskReport(props.taskReport, props.action) ? null : props.action.pendingAction}

    pendingAction={props.draftMessage ? null : props.action.pendingAction}

    Screen.Recording.2023-09-20.at.00.31.20.mov

    What alternative solutions did you explore? (Optional)

    NA

  8. dukenv0307 commented on Sep 20, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Web - Delete task message text color change in offline mode

    What is the root cause of that problem?

    We don't update pendingAction of parent report action to null in successData and failureData when we cancel the task

    const successData = [
    {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${taskReportID}`,
    value: {
    [optimisticReportActionID]: {
    pendingAction: null,
    },

    That makes this action is blurred in offline

    pendingAction={props.draftMessage ? null : props.action.pendingAction}

    What changes do you think we should make in order to solve the problem?

    We should update pendingAction of parent report action to null in successData and failureData

    const successData = [
    {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${taskReportID}`,
    value: {
    [optimisticReportActionID]: {
    pendingAction: null,
    },

    What alternative solutions did you explore? (Optional)

    NA

    Result

    Screen.Recording.2023-09-20.at.10.39.01.mp4
  9. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    @johncschuster, @robertKozik Eep! 4 days overdue now. Issues have feelings too...

  10. robertKozik commented on Sep 25, 2023

    @robertKozik
    Contributor

    Thank you both for your proposals @ZhenjaHorbach @dukenv0307 . I think the proper root cause was introduced by @dukenv0307 and solution tackles the cause directly. That's why I think we should proceed with @dukenv0307 proposal

    🎀 👀 🎀 C+ reviewed

  11. 33 remaining items

  12. johncschuster commented on Oct 20, 2023

    @johncschuster
    Contributor

    @gadhiyamanan, I just noticed you weren't invited to the job. I've just invited you directly on Upwork. Can you please accept the Reporter role? Thank you!

  13. gadhiyamanan commented on Oct 20, 2023

    @gadhiyamanan
    Contributor
  14. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    @johncschuster, @chiragsalian, @robertKozik, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. johncschuster commented on Oct 24, 2023

    @johncschuster
    Contributor

    @gadhiyamanan thanks! I've sent the proposal. Can you accept that? I'll get payment issued right away!

  16. gadhiyamanan commented on Oct 25, 2023

    @gadhiyamanan
    Contributor

    @johncschuster offer accepted, thanks!

  17. dukenv0307 commented on Oct 25, 2023

    @dukenv0307
    Contributor

    @johncschuster I was assigned on Step 26. I just created a draft on Step 25

    Screenshot 2023-10-25 at 10 22 36
  18. johncschuster commented on Oct 27, 2023

    @johncschuster
    Contributor

    Thanks for the ping, @dukenv0307! I thought the bonus was calculated on the date the PR is submitted, but it looks like I had that wrong! You are indeed eligible. Thanks for your patience while I confirmed that!

  19. johncschuster commented on Oct 27, 2023

    @johncschuster
    Contributor

    I've issued the bonus 🎉

  20. gadhiyamanan commented on Nov 7, 2023

    @gadhiyamanan
    Contributor

    @johncschuster can you please approve milestone in upwork?
    Payment is pending

  21. johncschuster commented on Nov 9, 2023

    @johncschuster
    Contributor

    Thank you for the ping, @gadhiyamanan! I've just issued payment. Sorry for missing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions