You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [$500] Dev: Web - Delete task message text color change in offline mode #27804
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.71-5 Reproducible in staging?: n Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Dev: Web - Delete task message text color change in offline mode[/-][+][$500] Dev: Web - Delete task message text color change in offline mode[/+]on Sep 19, 2023
Thank you both for your proposals @ZhenjaHorbach@dukenv0307 . I think the proper root cause was introduced by @dukenv0307 and solution tackles the cause directly. That's why I think we should proceed with @dukenv0307proposal
@gadhiyamanan, I just noticed you weren't invited to the job. I've just invited you directly on Upwork. Can you please accept the Reporter role? Thank you!
Thanks for the ping, @dukenv0307! I thought the bonus was calculated on the date the PR is submitted, but it looks like I had that wrong! You are indeed eligible. Thanks for your patience while I confirmed that!
Activity
[-]Dev: Web - Delete task message text color change in offline mode[/-][+][$500] Dev: Web - Delete task message text color change in offline mode[/+]melvin-bot commentedon Sep 19, 2023
Job added to Upwork: https://www.upwork.com/jobs/~014b184e9e64be3573
melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to @johncschuster (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (
External)ZhenjaHorbach commentedon Sep 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
Delete task item color should not change
What is the root cause of that problem?
We don't have the conditions for this
What changes do you think we should make in order to solve the problem?
We can update this line like
pendingAction={props.draftMessage || ReportUtils.isCanceledTaskReport(props.taskReport, props.action) ? null : props.action.pendingAction}App/src/pages/home/report/ReportActionItem.js
Line 621 in 6d67552
Screen.Recording.2023-09-20.at.00.31.20.mov
What alternative solutions did you explore? (Optional)
NA
dukenv0307 commentedon Sep 20, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Delete task message text color change in offline mode
What is the root cause of that problem?
We don't update
pendingActionof parent report action tonullinsuccessDataandfailureDatawhen we cancel the taskApp/src/libs/actions/Task.js
Lines 819 to 826 in d0b4912
That makes this action is blurred in offline
App/src/pages/home/report/ReportActionItem.js
Line 621 in d0b4912
What changes do you think we should make in order to solve the problem?
We should update
pendingActionof parent report action tonullinsuccessDataandfailureDataApp/src/libs/actions/Task.js
Lines 819 to 826 in d0b4912
What alternative solutions did you explore? (Optional)
NA
Result
Screen.Recording.2023-09-20.at.10.39.01.mp4
melvin-bot commentedon Sep 25, 2023
@johncschuster, @robertKozik Eep! 4 days overdue now. Issues have feelings too...
robertKozik commentedon Sep 25, 2023
Thank you both for your proposals @ZhenjaHorbach @dukenv0307 . I think the proper root cause was introduced by @dukenv0307 and solution tackles the cause directly. That's why I think we should proceed with @dukenv0307 proposal
🎀 👀 🎀 C+ reviewed
33 remaining items
johncschuster commentedon Oct 20, 2023
@gadhiyamanan, I just noticed you weren't invited to the job. I've just invited you directly on Upwork. Can you please accept the Reporter role? Thank you!
gadhiyamanan commentedon Oct 20, 2023
@johncschuster applied
melvin-bot commentedon Oct 23, 2023
@johncschuster, @chiragsalian, @robertKozik, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
johncschuster commentedon Oct 24, 2023
@gadhiyamanan thanks! I've sent the proposal. Can you accept that? I'll get payment issued right away!
gadhiyamanan commentedon Oct 25, 2023
@johncschuster offer accepted, thanks!
dukenv0307 commentedon Oct 25, 2023
@johncschuster I was assigned on Step 26. I just created a draft on Step 25
johncschuster commentedon Oct 27, 2023
Thanks for the ping, @dukenv0307! I thought the bonus was calculated on the date the PR is submitted, but it looks like I had that wrong! You are indeed eligible. Thanks for your patience while I confirmed that!
johncschuster commentedon Oct 27, 2023
I've issued the bonus 🎉
gadhiyamanan commentedon Nov 7, 2023
@johncschuster can you please approve milestone in upwork?
Payment is pending
johncschuster commentedon Nov 9, 2023
Thank you for the ping, @gadhiyamanan! I've just issued payment. Sorry for missing it!