You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-02] Chat - IOU - Hover is not being shown after stopping to scroll #27873
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The hover state is still set to false on scroll in the line below but the previous hover state can be set again if the original component is still hovered:
@Pluto0104 If you hover over a component and scroll a little bit while still hovering over the component, the hover effect disappears.
In Slack the hover effect is invisible while scrolling but becomes visible again when stopped on scrolling on the same component (Slack was referenced in that PR issue as an optimal behaviour)
[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be good.
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Go to any Report and start scrolling.
Once the scroll stops on an item, the hover effect should be visible.
Scroll slightly to remain in that item.
Verify the hover effect should disappear when you scroll and should come back when you stop.
Activity
melvin-bot commentedon Sep 20, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 20, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 20, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 20, 2023
Triggered auto assignment to @tylerkaraszewski (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.raymondchooi commentedon Sep 20, 2023
Proposal
Scroll while still hovering over component hides existing reaction/hover
What is the root cause of that problem?
isHoveredRef is set to false on scroll start and on scroll stop the state is set to isHoveredRef which is false
What changes do you think we should make in order to solve the problem?
Remove this line:
App/src/components/Hoverable/index.js
Line 49 in d00a4d6
The hover state is still set to false on scroll in the line below but the previous hover state can be set again if the original component is still hovered:
App/src/components/Hoverable/index.js
Line 50 in d00a4d6
What alternative solutions did you explore?
A timeout could be applied to handle when hover state should be checked again after scroll stop
Pluto0104 commentedon Sep 20, 2023
raymondchooi commentedon Sep 20, 2023
@Pluto0104 If you hover over a component and scroll a little bit while still hovering over the component, the hover effect disappears.
In Slack the hover effect is invisible while scrolling but becomes visible again when stopped on scrolling on the same component (Slack was referenced in that PR issue as an optimal behaviour)
26 remaining items
mollfpr commentedon Oct 3, 2023
#27236
The regression step should be good.
adelekennedy commentedon Oct 4, 2023
@mountiny @thienlnam what's the deal here - #27236 so is anyone due payment (I'm searching stack overflow and coming up short)
mountiny commentedon Oct 4, 2023
@adelekennedy its $500 to @mollfpr for reviewing and testing #27921
And then @Nathan-Mulugeta $50 for reporting this issue
adelekennedy commentedon Oct 5, 2023
Offer sent to @mollfpr and @Nathan-Mulugeta here
mollfpr commentedon Oct 5, 2023
@adelekennedy I think I can get paid from NewDot from now on. Confirm in #27087 (comment).
JmillsExpensify commentedon Oct 6, 2023
Can I get a payment summary on this issue so I can issue payment for @mollfpr?
mountiny commentedon Oct 6, 2023
@JmillsExpensify summary is
JmillsExpensify commentedon Oct 7, 2023
$500 payment approved for @mollfpr based on summary above.