Skip to content

[HOLD for payment 2023-10-02] Chat - IOU - Hover is not being shown after stopping to scroll #27873

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat where there are IOU cards and scrollable conversation
  2. Scroll and stop in the middle of an IOU card
  3. Move the mouse horizontally on the IOU card without moving up and down to hover over other components

Expected Result:

There should be a hover indicator and context menu should show up just after stopping scrolling even if user doesn't move the mouse up and down

Actual Result:

Hover indicator and context menu doesn't show up unless user hovers over other components and comes back

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.72-6

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-09-20.17.15.27.mp4
Recording.1565.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695219522514479

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 20, 2023
  2. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 20, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. raymondchooi commented on Sep 20, 2023

    @raymondchooi

    Proposal

    Scroll while still hovering over component hides existing reaction/hover

    What is the root cause of that problem?

    isHoveredRef is set to false on scroll start and on scroll stop the state is set to isHoveredRef which is false

    What changes do you think we should make in order to solve the problem?

    Remove this line:

    this.isHoveredRef = false;

    The hover state is still set to false on scroll in the line below but the previous hover state can be set again if the original component is still hovered:
    this.setState({isHovered: false}, this.props.onHoverOut);

    What alternative solutions did you explore?

    A timeout could be applied to handle when hover state should be checked again after scroll stop

  7. Pluto0104 commented on Sep 20, 2023

    @Pluto0104
  8. raymondchooi commented on Sep 20, 2023

    @raymondchooi

    @Pluto0104 If you hover over a component and scroll a little bit while still hovering over the component, the hover effect disappears.

    In Slack the hover effect is invisible while scrolling but becomes visible again when stopped on scrolling on the same component (Slack was referenced in that PR issue as an optimal behaviour)

  9. 26 remaining items

  10. mollfpr commented on Oct 3, 2023

    @mollfpr
    Contributor

    [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #27236

    [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    The regression step should be good.

    [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Go to any Report and start scrolling.
    2. Once the scroll stops on an item, the hover effect should be visible.
    3. Scroll slightly to remain in that item.
    4. Verify the hover effect should disappear when you scroll and should come back when you stop.
    5. 👍 or 👎
  11. adelekennedy commented on Oct 4, 2023

    @adelekennedy
    Contributor

    @mountiny @thienlnam what's the deal here - #27236 so is anyone due payment (I'm searching stack overflow and coming up short)

  12. mountiny commented on Oct 4, 2023

    @mountiny
    Contributor

    @adelekennedy its $500 to @mollfpr for reviewing and testing #27921

    And then @Nathan-Mulugeta $50 for reporting this issue

  13. adelekennedy commented on Oct 5, 2023

    @adelekennedy
    Contributor

    Offer sent to @mollfpr and @Nathan-Mulugeta here

  14. mollfpr commented on Oct 5, 2023

    @mollfpr
    Contributor

    @adelekennedy I think I can get paid from NewDot from now on. Confirm in #27087 (comment).

  15. JmillsExpensify commented on Oct 6, 2023

    @JmillsExpensify
    Contributor

    Can I get a payment summary on this issue so I can issue payment for @mollfpr?

  16. mountiny commented on Oct 6, 2023

    @mountiny
    Contributor

    @JmillsExpensify summary is

  17. JmillsExpensify commented on Oct 7, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @mollfpr based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions