Skip to content

[HOLD for payment 2024-01-09] [HOLD for payment 2023-12-26] HIGH: [$500] Show workspace interstitial when trying to create a room with no workspace #27995

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com.
  2. Log in as user with no workspace.
  3. Go to + > Send message > Room.

Expected Result:

When there is no workspace found, then clicking on Room will lead to the following screens:

image

Actual Result:

User is presented with 'Hmm.. it's not here' message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.72-9

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6208778_20230921_141704.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010e79d9d183706783
  • Upwork Job ID: 1712078763933061120
  • Last Price Increase: 2023-10-18
  • Automatic offers:
    • hoangzinh | Reviewer | 27276980
Issue OwnerCurrent Issue Owner: @RobertLadue

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 22, 2023
  2. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. c3024 commented on Sep 22, 2023

    @c3024
    Contributor

    There is a bug raised for double back icons here for this same case. We are working on this solution here in this PR.

    If there is a specific behavior we would like to have for this case, it can be worked out in this PR.

    Also this is a new feature, so I think not a blocker.

    cc: @eVoloshchak @flodnv

  7. situchan commented on Sep 22, 2023

    @situchan
    Contributor

    I don't think this is blocker but UX improvement, though I thought not found page was intentional.
    There was not such page before new global create refactor.
    cc: @thienlnam

  8. c3024 commented on Sep 22, 2023

    @c3024
    Contributor

    I think the best choice is to not show the # Room option at all when there is no workspace available.

    We can use the same condition that is used in WorkspaceNewRoomPage for showing the error in the NewChatSelectorPage.

    We can use this

    const workspaceOptions = useMemo(() => _.map(PolicyUtils.getActivePolicies(props.policies), (policy) => ({label: policy.name, key: policy.id, value: policy.id})), [props.policies]);

    and
    <FullPageNotFoundView shouldShow={!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length}>

    in NewChatSelectorPageand use this same condition to hide the # Room when there is no workspace available.

    We can make a function getWorkspaceOptions in PolicyUtils to make the code DRY and reuse in both the pages.

    Screen.Recording.2023-09-22.at.5.19.46.PM.mov

    cc @thienlnam

  9. 148 remaining items

  10. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 11, 2024
  11. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  12. bfitzexpensify commented on Jan 11, 2024

    @bfitzexpensify
    Contributor

    I'm mostly ooo until Jan 29 so tagging in another BZ team member to close this out.

    @mallenexpensify the only item left is to complete payment to @dukenv0307 via https://www.upwork.com/ab/applicants/1745464644211769344/job-details.

    @dukenv0307, please comment in this issue when you've accepted that offer.

  13. dukenv0307 commented on Jan 15, 2024

    @dukenv0307
    Contributor

    @dukenv0307, please comment in this issue when you've accepted that offer.

    @bfitzexpensify I accepted, thank you!

  14. melvin-bot commented on Jan 18, 2024

    @melvin-bot

    @hoangzinh, @mallenexpensify, @techievivek, @bfitzexpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. bfitzexpensify commented on Jan 18, 2024

    @bfitzexpensify
    Contributor

    Payment complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.Waiting for copyUser facing verbiage needs polishing

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions