You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-09] [HOLD for payment 2023-12-26] HIGH: [$500] Show workspace interstitial when trying to create a room with no workspace #27995
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I don't think this is blocker but UX improvement, though I thought not found page was intentional.
There was not such page before new global create refactor.
cc: @thienlnam
Activity
melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to @techievivek (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.c3024 commentedon Sep 22, 2023
There is a bug raised for double back icons here for this same case. We are working on this solution here in this PR.
If there is a specific behavior we would like to have for this case, it can be worked out in this PR.
Also this is a new feature, so I think not a blocker.
cc: @eVoloshchak @flodnv
situchan commentedon Sep 22, 2023
I don't think this is blocker but UX improvement, though I thought not found page was intentional.
There was not such page before new global create refactor.
cc: @thienlnam
c3024 commentedon Sep 22, 2023
I think the best choice is to not show the # Room option at all when there is no workspace available.
We can use the same condition that is used in
WorkspaceNewRoomPagefor showing the error in theNewChatSelectorPage.We can use this
App/src/pages/workspace/WorkspaceNewRoomPage.js
Line 122 in 2a5ea63
and
App/src/pages/workspace/WorkspaceNewRoomPage.js
Line 147 in 2a5ea63
in
NewChatSelectorPageand use this same condition to hide the # Room when there is no workspace available.We can make a function getWorkspaceOptions in PolicyUtils to make the code DRY and reuse in both the pages.
Screen.Recording.2023-09-22.at.5.19.46.PM.mov
cc @thienlnam
148 remaining items
melvin-bot commentedon Jan 11, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.bfitzexpensify commentedon Jan 11, 2024
I'm mostly ooo until Jan 29 so tagging in another BZ team member to close this out.
@mallenexpensify the only item left is to complete payment to @dukenv0307 via https://www.upwork.com/ab/applicants/1745464644211769344/job-details.
@dukenv0307, please comment in this issue when you've accepted that offer.
dukenv0307 commentedon Jan 15, 2024
@bfitzexpensify I accepted, thank you!
melvin-bot commentedon Jan 18, 2024
@hoangzinh, @mallenexpensify, @techievivek, @bfitzexpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
bfitzexpensify commentedon Jan 18, 2024
Payment complete.