Repository navigation
[$500] [Awaiting Payment]2FA login - Error message shows incorrect 2FA code when incorrect recovery code is used #28044
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #23390
Action Performed:
Precondition:
- User has set up 2FA and saved the recovery codes.
- User has previously used one of the recovery codes.
- Go to login page.
- Enter email and magic code.
- Click Use recovery code.
- Use the recovery code that has already been used before.
5.Click Sign in.
Expected Result:
The error message mentions incorrect recovery code.
Actual Result:
The error message mentions two-factor authentication code instead of recovery code.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6210906_20230922_222809.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695308760173509
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~011dfd59ea4353f356
- Upwork Job ID: 1711516319487270912
- Last Price Increase: 2023-10-09
Activity
OSBotify commentedon Sep 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to @chiragsalian (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mountiny commentedon Sep 25, 2023
@alitoshmatov @abdulrahuman5196 @MonilBhavsar Seems like a regression from your PR?
I dont think this is that important though to be a blocker, its not blocking user from logging in and also its rare to use recovery code and the one you have already used. Demoting to a bug and we should fix this probably as a regression from the PR
melvin-bot commentedon Sep 25, 2023
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 25, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)33 remaining items
puneetlath commentedon Oct 9, 2023
Upwork seems to be having issues. Will try again later.
[-][Awaiting Payment]2FA login - Error message shows incorrect 2FA code when incorrect recovery code is used[/-][+][$500] [Awaiting Payment]2FA login - Error message shows incorrect 2FA code when incorrect recovery code is used[/+]melvin-bot commentedon Oct 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~011dfd59ea4353f356
melvin-bot commentedon Oct 9, 2023
Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.
puneetlath commentedon Oct 9, 2023
@ayazhussain79 sent you an offer.
ayazhussain79 commentedon Oct 10, 2023
@puneetlath offer accepted, Thank you
puneetlath commentedon Oct 10, 2023
All paid!