[HOLD for payment 2023-10-16] [$500] Chat - LHN disappears after leaving a thread

@bernhardoj

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open any chat
Send any message
Press reply in thread on the message
Send any message on the thread
Refresh the web
Leave the thread

Expected Result:

LHN still visible

Actual Result:

LHN disappears, on mobile web, you can't go back to LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-21.at.23.42.57.mov

Recording.4734.mp4

Expensify/Expensify Issue URL:
Issue reported by:@bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695311611076489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012668216660b5477f
Upwork Job ID: 1705957196467560448
Last Price Increase: 2023-10-01
Automatic offers:

dukenv0307 | Contributor | 26994431

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~012668216660b5477f

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@dylanexpensify

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@eVoloshchak

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Left Handed Menu dissapears on "Leave thread" action.

What is the root cause of that problem?

There is no return statement, when code reaches on of the checks, thats the reason why code gets into second if statement

What changes do you think we should make in order to solve the problem?

Add return statement in file src/libs/actions/Report.js on line 1891:

Navigation.dismissModal();
if (Navigation.getTopmostReportId() === reportID) {
    Navigation.goBack(ROUTES.HOME);   <---- This is the problem
}
if (report.parentReportID) {
    Navigation.navigate(ROUTES.getReportRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP);
    return;
}

navigateToConciergeChat();

Before return;

before_return.mp4

After return;

after_return.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN disappears, on mobile web, you can't go back to LHN

What is the root cause of that problem?

Here we're force-navigate to the report screen, which will replace the current Home screen and cause the LHN to disappear.

What changes do you think we should make in order to solve the problem?

We should move this block to above this block. Since we'll be navigating to the parent report screen anyway so no need to go back to home screen before that.

What alternative solutions did you explore? (Optional)

We can use push navigate here rather than force navigate.

payment upcoming!

The PR that introduced the bug has been identified. Link to the PR: Fix: Leaving thread navigates to Concierge page #27127
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27127/files#r1365870668
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is an edge case with navigation, there isn't much we could do in terms of improving our checklists/processes besides more thorough testing
Determine if we should create a regression test for this bug.
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? Yes
Is it an impactful bug? Yes
I think we should implement a regression test here, the bug is pretty severe

Regression Test Proposal

Open a report and send a message
Click on reply in thread of this message
Send a message in the thread
Refresh the page
Click on the header title (thread name) to bring up the Details menu
Select "Leave Thread"
Verify that you're redirected to the parent report
Verify LHN isn't hidden

Do we agree 👍 or 👎

@arosiclair

@arosiclair, @eVoloshchak, @bfitzexpensify, @dylanexpensify, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@eVoloshchak

$750 approved for @eVoloshchak based on summary above.

@dukenv0307

Regression test steps look good, proposed they be added in https://github.com/Expensify/Expensify/issues/329592.

Payment made to @dukenv0307, just need to finalize payment for @bernhardoj for the reporter role.

OK, all done here, thanks everyone.

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-16] [$500] Chat - LHN disappears after leaving a thread #28087

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

34 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-10-16] [$500] Chat - LHN disappears after leaving a thread #28087

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 24, 2023

melvin-bot commented on Sep 24, 2023

melvin-bot commented on Sep 24, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Sep 24, 2023

melvin-bot commented on Sep 24, 2023

RichardPickman commented on Sep 24, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

dukenv0307 commented on Sep 25, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

34 remaining items

dylanexpensify commented on Oct 18, 2023

eVoloshchak commented on Oct 19, 2023

eVoloshchak commented on Oct 19, 2023

melvin-bot commented on Oct 23, 2023

JmillsExpensify commented on Oct 23, 2023

bfitzexpensify commented on Oct 24, 2023

bfitzexpensify commented on Oct 27, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions