[HOLD for payment 2023-10-13] [$500] Login - Enter key does not submit recovery code

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #23390

Action Performed:

Go to https://staging.new.expensify.com
Enter the email of an account with 2FA enabled.
Enter magic code
Click Use recovery code
Enter any incorrect code
Hit Enter

Expected Result:

Enter key submits the recovery code. Error will show up

Actual Result:

Enter key does not submit the recovery code. No error shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.73-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6212637_20230923_200402.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e8bad5388f05b443
Upwork Job ID: 1706566640146960384
Last Price Increase: 2023-09-26
Automatic offers:

abdulrahuman5196 | Contributor | 26933666

@tjferriss

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@tylerkaraszewski

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing Enter key does nothing on login recovery code page

What is the root cause of that problem?

On press enter key, TextInput's onSubmitEditing callback is called but it's not implemented here:

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 298 to 308 in 4ea4a55

    
           <TextInput 
        
               shouldDelayFocus 
        
               accessibilityLabel={props.translate('recoveryCodeForm.recoveryCode')} 
        
               value={recoveryCode} 
        
               onChangeText={(text) => onTextInput(text, 'recoveryCode')} 
        
               maxLength={CONST.RECOVERY_CODE_LENGTH} 
        
               label={props.translate('recoveryCodeForm.recoveryCode')} 
        
               errorText={formError.recoveryCode ? props.translate(formError.recoveryCode) : ''} 
        
               hasError={hasError} 
        
               autoFocus 
        
           />

What changes do you think we should make in order to solve the problem?

Add that callback:
onSubmitEditing={validateAndSubmitForm}

What alternative solutions did you explore? (Optional)

Additionally, pass pressOnEnter={props.isUsingRecoveryCode} to Button if we'd like to submit on enter even when input is not focused. There will not be duplicated call thanks to isLoading check here.

@tylerkaraszewski

I'm able to reproduce. At first I thought there was no error because I clicked on the Sign In after entering the incorrect recovery code. As the instructions outline, you need to use the "Enter" button to reproduce the issue.

I'm not sure this qualifies as a deploy blocker. The user can still enter an incorrect code, just not in their preferred way by clicking or tapping "Enter". @tylerkaraszewski do you view this as a deploy blocker?

Proposal

I don't think this is a DB because user still can use the app.

Please re-state the problem that we are trying to solve in this issue.

Login - Enter key does not submit recovery code

What is the root cause of that problem?

Currently we didn't pass the pressOnEnter props to our submit button here, so when we press enter, nothing happen because we're using TextInput for recovery code (others used MagicCodeInput).

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 379 to 388 in 19f93db

    
           <Button 
        
               isDisabled={props.network.isOffline} 
        
               success 
        
               style={[styles.mv3]} 
        
               text={props.translate('common.signIn')} 
        
               isLoading={ 
        
                   props.account.isLoading && props.account.loadingForm === (props.account.requiresTwoFactorAuth ? CONST.FORMS.VALIDATE_TFA_CODE_FORM : CONST.FORMS.VALIDATE_CODE_FORM) 
        
               } 
        
               onPress={validateAndSubmitForm} 
        
           />

What changes do you think we should make in order to solve the problem?

We should add pressOnEnter to our SignIn button incase we're using recovery code:

                <Button
                    isDisabled={props.network.isOffline}
                    success
                    style={[styles.mv3]}
                    text={props.translate('common.signIn')}
                    isLoading={
                        props.account.isLoading && props.account.loadingForm === (props.account.requiresTwoFactorAuth ? CONST.FORMS.VALIDATE_TFA_CODE_FORM : CONST.FORMS.VALIDATE_CODE_FORM)
                    }
                    pressOnEnter={isUsingRecoveryCode}
                    onPress={validateAndSubmitForm}
                />

What alternative solutions did you explore? (Optional)

N/A

@abdulrahuman5196

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

This was regression from original PR, so updating assignees

Reviewing label has been removed, please complete the "BugZero Checklist".

@abdulrahuman5196

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Submit recovery code when enter is pressed #28409

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@abdulrahuman5196 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@abdulrahuman5196

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@alitoshmatov

Payment Summary:

Contributor @alitoshmatov $500
Reviewer @abdulrahuman5196 $500

@tjferriss

@tjferriss This was a follow up PR and does not require payment - #22335 (comment)

@tjferriss

@tjferriss No payment needed here as discussed - #22335 (comment)

We can close this issue directly.

Yes, thanks everyone! We can close this one 👍

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-13] [$500] Login - Enter key does not submit recovery code #28092

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

25 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<TextInput
	shouldDelayFocus
	accessibilityLabel={props.translate('recoveryCodeForm.recoveryCode')}
	value={recoveryCode}
	onChangeText={(text) => onTextInput(text, 'recoveryCode')}
	maxLength={CONST.RECOVERY_CODE_LENGTH}
	label={props.translate('recoveryCodeForm.recoveryCode')}
	errorText={formError.recoveryCode ? props.translate(formError.recoveryCode) : ''}
	hasError={hasError}
	autoFocus
	/>

	<Button
	isDisabled={props.network.isOffline}
	success
	style={[styles.mv3]}
	text={props.translate('common.signIn')}
	isLoading={
	props.account.isLoading && props.account.loadingForm === (props.account.requiresTwoFactorAuth ? CONST.FORMS.VALIDATE_TFA_CODE_FORM : CONST.FORMS.VALIDATE_CODE_FORM)
	}
	onPress={validateAndSubmitForm}
	/>

[HOLD for payment 2023-10-13] [$500] Login - Enter key does not submit recovery code #28092

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 24, 2023

melvin-bot commented on Sep 24, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Sep 24, 2023

melvin-bot commented on Sep 24, 2023

mkhutornyi commented on Sep 24, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

tjferriss commented on Sep 25, 2023

hungvu193 commented on Sep 25, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

25 remaining items

melvin-bot commented on Sep 29, 2023

MonilBhavsar commented on Sep 29, 2023

melvin-bot commented on Oct 6, 2023

melvin-bot commented on Oct 6, 2023

melvin-bot commented on Oct 6, 2023

tjferriss commented on Oct 6, 2023

alitoshmatov commented on Oct 7, 2023

abdulrahuman5196 commented on Oct 7, 2023

MonilBhavsar commented on Oct 9, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions