You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-13] [$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown #28169
When user edit comment and send quote message with strike through markdown, the vertical line must not display big and "edited" status of message must be shown
Actual Result:
When user send quote message with bold markdown, it is correctly applied. When user edited comment and send quote message with italic markdown, it is displayed correctly with " Edited " status. But when user edit comment and send quote message with strike through markdown, the vertical line displays big and "edited" status of message is not shown
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.74-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown[/-][+][HOLD for payment 2023-10-13] [$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown[/+]on Oct 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
[@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@narefyev91] Determine if we should create a regression test for this bug.
[@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
External issue reporter. - n/a reported by applause
Contributor that fixed the issue - paid $750 ($500 + $250 urgency)
Contributor+ that helped on the issue and/or PR - expert agency should be paid via invoice.
Activity
melvin-bot commentedon Sep 25, 2023
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 25, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 25, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 25, 2023
Triggered auto assignment to @tylerkaraszewski (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.marcaaron commentedon Sep 27, 2023
Seems most likely related to #28113
marcaaron commentedon Sep 27, 2023
FWIW, seems to be working fine on web and desktop. Can't reproduce there.
zanyrenney commentedon Sep 27, 2023
I also can't reproduce this @marcaaron
25 remaining items
melvin-bot commentedon Oct 4, 2023
🎯 ⚡️ Woah @narefyev91 / @abdel-h66, great job pushing this forwards! ⚡️
The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀
[-][$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown[/-][+][HOLD for payment 2023-10-13] [$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown[/+]melvin-bot commentedon Oct 6, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
zanyrenney commentedon Oct 16, 2023
PAYMENT SUMMARY
External issue reporter. - n/a reported by applause
Contributor that fixed the issue - paid $750 ($500 + $250 urgency)
Contributor+ that helped on the issue and/or PR - expert agency should be paid via invoice.