Skip to content

[HOLD for payment 2023-10-13] [$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown #28169

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch app
  2. Tap on a report
  3. Enter >×××× and send it
  4. Long press the sent message and tap edit comment
  5. Enter >×××× and send it
  6. Long press the sent message and tap edit comment
  7. Enter >×××× and send it

Expected Result:

When user edit comment and send quote message with strike through markdown, the vertical line must not display big and "edited" status of message must be shown

Actual Result:

When user send quote message with bold markdown, it is correctly applied. When user edited comment and send quote message with italic markdown, it is displayed correctly with " Edited " status. But when user edit comment and send quote message with strike through markdown, the vertical line displays big and "edited" status of message is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.74-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6213807_quote_strike.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0106a55a980636498f
  • Upwork Job ID: 1707682565947748352
  • Last Price Increase: 2023-09-29
  • Automatic offers:
    • abdel-h66 | Contributor | 26983210

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 25, 2023
  2. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 25, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. marcaaron commented on Sep 27, 2023

    @marcaaron
    Contributor

    Seems most likely related to #28113

  7. marcaaron commented on Sep 27, 2023

    @marcaaron
    Contributor

    FWIW, seems to be working fine on web and desktop. Can't reproduce there.

  8. zanyrenney commented on Sep 27, 2023

    @zanyrenney
    Contributor

    I also can't reproduce this @marcaaron

  9. 25 remaining items

  10. melvin-bot commented on Oct 4, 2023

    @melvin-bot

    🎯 ⚡️ Woah @narefyev91 / @abdel-h66, great job pushing this forwards! ⚡️

    The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

    • when @abdel-h66 got assigned: 2023-10-02 16:28:43 Z
    • when the PR got merged: 2023-10-04 16:49:46 UTC

    On to the next one 🚀

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 6, 2023
  12. changed the title [-][$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown[/-] [+][HOLD for payment 2023-10-13] [$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown[/+] on Oct 6, 2023
  13. melvin-bot commented on Oct 6, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Oct 6, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-13. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Oct 6, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
    • [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@narefyev91] Determine if we should create a regression test for this bug.
    • [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. zanyrenney commented on Oct 16, 2023

    @zanyrenney
    Contributor

    PAYMENT SUMMARY

    External issue reporter. - n/a reported by applause
    Contributor that fixed the issue - paid $750 ($500 + $250 urgency)
    Contributor+ that helped on the issue and/or PR - expert agency should be paid via invoice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions