[HOLD for payment 2023-10-09] [$500] Dev: Lounge Access - Display name with no spacing on LoungeAccess page.

@hungvu193

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Change your display name to very long name
Go to Settings => Profile => Lounge Access.
Observer the Display name.

Expected Result:

Display name should have the spacing left, right.

Actual Result:

Display name with no spacing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev 1.3.69-1
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-14.at.13.37.25.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694673434455339

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015a75a17aaf196848
Upwork Job ID: 1706652568219099136
Last Price Increase: 2023-09-26
Automatic offers:

hungvu193 | Contributor | 26897544
hungvu193 | Reporter | 26897545

Issue Owner

Current Issue Owner: @zanyrenney

Job added to Upwork: https://www.upwork.com/jobs/~015a75a17aaf196848

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@hungvu193

Proposal by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694673434455339

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We didn't have the padding horizontal for our overlayContent here, which caused the issue:

App/src/pages/settings/Profile/LoungeAccessPage.js

Line 72 in d68263a

    
           <View style={[styles.flex1, styles.justifyContentCenter, styles.alignItemsCenter, styles.pt5]}>

What changes do you think we should make in order to solve the problem?

We should add styles.ph5 here to make overlayContent has horizontal padding.

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2023-09-14.at.13.49.00.mov

Proposal

Please re-state the problem that we are trying to solve in this issue.

Lounge Access - Display name with no spacing on LoungeAccess page.

What is the root cause of that problem?

We didn't have the padding horizontal for overlayContent here.

 <View style={[styles.flex1, styles.justifyContentCenter, styles.alignItemsCenter, styles.pt5]}>

What changes do you think we should make in order to solve the problem?

We should add styles.avatarSectionWrapper to the view styles and remove styles.alignItemsCenter

What alternative solutions did you explore? (Optional)

@kbecciv

@kbecciv Please assign bug label as well.

@hungvu193

Ok, @hungvu193 's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

@Julesssss

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hungvu193

Proposal by: @hungvu193

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694673434455339

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We didn't have the padding horizontal for our overlayContent here, which caused the issue:

App/src/pages/settings/Profile/LoungeAccessPage.js

Line 72 in d68263a

<View style={[styles.flex1, styles.justifyContentCenter, styles.alignItemsCenter, styles.pt5]}>

What changes do you think we should make in order to solve the problem?

We should add styles.ph5 here to make overlayContent has horizontal padding.

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2023-09-14.at.13.49.00.mov

@Julesssss

Yep, on it @Julesssss

@hungvu193

PAYMENT SUMMARY

@hungvu193 requires payment offer (Contributor) - PAID $50
@parasharrajat does not require payment (Eligible for Manual Requests) - N/A
@hungvu193 requires payment offer (Contributor) - PAID $750, $500 + $250 URGENCY.

Thanks Zany!

Payment requested as per #28256 (comment)

@zanyrenney

@zanyrenney Can you please fix the payment summary to include the amount for me? It says N/A

@zanyrenney

@zanyrenney Mind updating your payment summary with the amount that should be paid? Re-open for that part.

@hungvu193

PAYMENT SUMMARY

@hungvu193 requires payment offer (Contributor) - PAID $50
@parasharrajat does not require payment (Eligible for Manual Requests) - due $750 - $500 + $250 urgency
@hungvu193 requires payment offer (Contributor) - PAID $750, $500 + $250 URGENCY.

@parasharrajat

$750 payment approved for @parasharrajat based on summary above.

closing!

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-09] [$500] Dev: Lounge Access - Display name with no spacing on LoungeAccess page. #28256

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

34 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-10-09] [$500] Dev: Lounge Access - Display name with no spacing on LoungeAccess page. #28256

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 26, 2023

melvin-bot commented on Sep 26, 2023

kbecciv commented on Sep 26, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ishpaul777 commented on Sep 26, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

parasharrajat commented on Sep 26, 2023

parasharrajat commented on Sep 26, 2023

melvin-bot commented on Sep 26, 2023

hungvu193 commented on Sep 27, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

34 remaining items

zanyrenney commented on Oct 16, 2023

zanyrenney commented on Oct 16, 2023

Julesssss commented on Oct 16, 2023

parasharrajat commented on Dec 5, 2023

parasharrajat commented on Dec 5, 2023

JmillsExpensify commented on Dec 11, 2023

zanyrenney commented on Dec 12, 2023

JmillsExpensify commented on Dec 12, 2023

zanyrenney commented on Dec 13, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions