Repository navigation
[HOLD for payment 2023-10-09] [$500] Dev: Request Money - The app crashes when clicking on the currency option #28317
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open a chat
- Go to the "Request money"
- Click on the currency option
Expected Result:
The app should not crash
Actual Result:
The app crashes when clicking on the currency option.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native -requested
- Android / Chrome -requested
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: Dev
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-09-27.at.12.19.03.PM.mov
Screen.Recording.2023-09-27.at.12.15.09.PM.mov
Screen.Recording.2023-09-27.at.12.13.02.PM.mov
screen-recording-2023-09-27-at-113442-am_X1UAbmMm.mp4
Expensify/Expensify Issue URL:
Issue reported by: ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695796696023189
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~011cb9c04584439771
- Upwork Job ID: 1707041619621773312
- Last Price Increase: 2023-09-27
- Automatic offers:
- situchan | Contributor | 27157044
Activity
[-]Dev: Request Money - The app crashes when clicking on the currency option[/-][+][$500] Dev: Request Money - The app crashes when clicking on the currency option[/+]melvin-bot commentedon Sep 27, 2023
Job added to Upwork: https://www.upwork.com/jobs/~011cb9c04584439771
melvin-bot commentedon Sep 27, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)hungvu193 commentedon Sep 27, 2023
It seems regression from this:
#27850
This line introduced the bugs, the currency option don't have the icons, we should have safety check there
cc @bernhardoj
bernhardoj commentedon Sep 27, 2023
@hungvu193 yes, you're right. Thanks for the help. I have created a PR to fix it.
mananjadhav commentedon Sep 27, 2023
I don't see any BZ member added. @bernhardoj Can you assign the original C+ here for the review? or another C+? Because I am afk right now.
bernhardoj commentedon Sep 27, 2023
I can't assign people, so tagging @narefyev91 for visibility. I have tagged him on the PR too.
hungvu193 commentedon Sep 27, 2023
That's pretty weird that Melvin added the weekly label, I think that's why there's no BZ assignment 😂
30 remaining items
situchan commentedon Nov 9, 2023
@sonialiap bump ^
sonialiap commentedon Nov 13, 2023
Offer sentwithdrawn in favor of Offer link. Payment made for $500situchan commentedon Nov 14, 2023
I already got offer here
sonialiap commentedon Nov 14, 2023
Payment sent ✔️
ayazhussain79 commentedon Nov 14, 2023
@sonialiap could you please check am i eligible for reporting bonus?
sonialiap commentedon Nov 17, 2023
Checking!
sonialiap commentedon Nov 17, 2023
@ayazhussain79 Ah yes of course! Thank you for bringing it up 👍 Offer sent
Reporting $50 - paid ✔️
ayazhussain79 commentedon Nov 17, 2023
@sonialiap offer accepted, Thank you
sonialiap commentedon Nov 20, 2023
Paid ✔️