[$500] iOS - Send message - "You appear to be offline.'' message is shown twice in IOS in New Chat Page

@rayane-djouah

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Login on the IOS app with a new account
go to settings > preferences > and check force offline
click on the + floating action button
click send message
observe the ''You appear to be offline'' message in the New Chat Page

Expected Result:

'You appear to be offline.'' message is shown once in IOS in New Chat Page

Actual Result:

''You appear to be offline.'' message is shown twice in IOS in New Chat Page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @rayane-djouah

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695728283307099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bfe5272e5528fa4d
Upwork Job ID: 1707065051587596288
Last Price Increase: 2023-10-11

Job added to Upwork: https://www.upwork.com/jobs/~01bfe5272e5528fa4d

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@rushatgabhane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@rayane-djouah

Proposal from @rayane-djouah

Please re-state the problem that we are trying to solve in this issue.

''You appear to be offline.'' message is shown twice in New Chat Page

What is the root cause of that problem?

the ScreenWrapper in NewChatPage component is showing a second offline message in addition to the existing one of the high level component.

What changes do you think we should make in order to solve the problem?

we should add shouldShowOfflineIndicator={false} for the ScreenWrapper in NewChatPage

App/src/pages/NewChatPage.js

Lines 171 to 177 in cfad43f

    
           <ScreenWrapper 
        
               shouldEnableKeyboardAvoidingView={false} 
        
               includeSafeAreaPaddingBottom={false} 
        
               includePaddingTop={false} 
        
               shouldEnableMaxHeight 
        
               testID={NewChatPage.displayName} 
        
           >

Result:
https://github.com/Expensify/App/assets/77965000/adae6aa1-1cad-4546-a197-d07dd119d2d8

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

When offline, “You appear to be offline.'' message is shown twice in IOS in New Chat Selector Page. Only once it must be shown.

What is the root cause of that problem?

As shown here in the NewChatSelectorPage, the new chat selector page can either show NewChatPage or a tab with NewChatPage or WorkspaceNewRoomPage. Since NewChatPage and WorkspaceNewRoomPage are both showing Offline Indicator within their ScreenWrapper, the ScreenWrapper within NewChatSelectorPage will also duplicate the display of Offline Indicator. This is the root cause.

What changes do you think we should make in order to solve the problem?

To solve this problem, we can disable Offline Indicator for NewChatSelectorPage by setting shouldShowOfflineIndicator property to false in ScreenWrapper here as follows:

        <ScreenWrapper
            shouldEnableKeyboardAvoidingView={false}
            includeSafeAreaPaddingBottom={false}
            shouldEnableMaxHeight
+	    shouldShowOfflineIndicator={false}
            testID={NewChatSelectorPage.displayName}
        >

This will ensure that the duplicate Offline Indicator is not shown for both NewChatPage and WorkspaceNewRoomPage.

What alternative solutions did you explore? (Optional)

Updated Proposal

original proposal link

Please re-state the problem that we are trying to solve in this issue.

''You appear to be offline.'' message is shown twice in New Chat Page and New Room Page

What is the root cause of that problem?

the ScreenWrapper in NewChatPage component and the ScreenWrapper in WorkspaceNewRoomPage are showing a second offline message in addition to the existing one in the ScreenWrapper of the higher order component NewChatSelectorPage.

What changes do you think we should make in order to solve the problem?

we should set shouldShowOfflineIndicator property to false in the the ScreenWrapper in NewChatPage component and the ScreenWrapper in WorkspaceNewRoomPage

<ScreenWrapper
    shouldEnableKeyboardAvoidingView={false}
    includeSafeAreaPaddingBottom={false}
    includePaddingTop={false}
    shouldEnableMaxHeight
+    shouldShowOfflineIndicator={false}
    testID={NewChatPage.displayName}
>

<ScreenWrapper
    shouldEnableKeyboardAvoidingView={false}
    includeSafeAreaPaddingBottom={false}
    includePaddingTop={false}
    shouldEnablePickerAvoiding={false}
+    shouldShowOfflineIndicator={false}
    testID={WorkspaceNewRoomPage.displayName}
>

What alternative solutions did you explore? (Optional)

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@rushatgabhane

bump @rushatgabhane can you review the proposal?

@rushatgabhane

@rushatgabhane, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kbecciv

Have confirmed can't reproduce on iphone and @kbecciv also confirmed in the thread, closing!

@kbecciv

Have confirmed can't reproduce on iphone and @kbecciv also confirmed in the thread, closing!

@zanyrenney @kbecciv
Can you please reconfirm reproducing this bug?
The reason for my request is that I am still able to reproduce this bug.
Please refer to the attached video that reproduces this issue for me.

28326-issue.mp4

@zanyrenney

@zanyrenney
I fail to understand why this issue is closed as I can still reproduce this in v 1.3.91-6
Anything I am missing here?

Here is a test video that reproduces the problem:

28326-reproduced.mp4

@zanyrenney

@zanyrenney this is still reproducible. Maybe we can reopen and fix this for $125 as it's super minor?

Maybe we can reopen and fix this for $125 as it's super minor?

I can understand price being reduced initially itself. Or I can even understand price being reduced before receiving any proposals.
As I understand, sometimes the fix is simple and sometimes it takes much more time. So, overall, it get’s balanced. But, this does not mean that we can ignore the time spent to investigate.
To me, defining an issue super minor after receiving proposals does not sound fair.
Do we have any parallel to substantiate the previous comment?
Maybe, I am missing something here.

Do we have any parallel to substantiate the previous comment?

Example: #29459 (comment), though it end up being complex

Example: #29459 (comment), though it end up being complex

Yes. Agree that it is complex. But, I doubt if we can draw a parallel with that issue.
I have had experiences where the issue was closed by stating it as a non-issue even after I sent proposals. But, then, I can understand.
Anyway, to me, this issue happens in a typical flow of starting a new chat. And, I think, we cannot ignore it.
Looks like the confusion is in connection with reproducing this issue.

Navigation Menu

Repository navigation

[$500] iOS - Send message - "You appear to be offline.'' message is shown twice in IOS in New Chat Page #28326

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal from @rayane-djouah

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Updated Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<ScreenWrapper
	shouldEnableKeyboardAvoidingView={false}
	includeSafeAreaPaddingBottom={false}
	includePaddingTop={false}
	shouldEnableMaxHeight
	testID={NewChatPage.displayName}
	>

[$500] iOS - Send message - "You appear to be offline.'' message is shown twice in IOS in New Chat Page #28326

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 27, 2023

melvin-bot commented on Sep 27, 2023

melvin-bot commented on Sep 27, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Sep 27, 2023

izarutskaya commented on Sep 27, 2023

Proposal from @rayane-djouah

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

rojiphil commented on Sep 27, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

rayane-d commented on Sep 27, 2023

Updated Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

13 remaining items

melvin-bot commented on Oct 11, 2023

zanyrenney commented on Oct 12, 2023

melvin-bot commented on Oct 16, 2023

zanyrenney commented on Oct 16, 2023

rojiphil commented on Oct 16, 2023

rojiphil commented on Oct 27, 2023

situchan commented on Oct 27, 2023

rojiphil commented on Oct 27, 2023

situchan commented on Oct 27, 2023

rojiphil commented on Oct 27, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions