Repository navigation
[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Chat - Error appears on click of notification and does not redirect to page #28328
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- From userA, send message to userB
- From userB, click on the notification
Expected Result:
It should redirect to userA chat
Actual Result:
Nothing happens on click of notification and console error appears (ROUTES__WEBPACK_IMPORTED_MODULE_13_.default.getReportRoute is not a function)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari -requested
- MacOS / Desktop
Version Number: Dev 1.3.74-2
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-09-26.at.11.58.34.AM.1.mov
Screen.Recording.2023-09-28.at.11.06.03.AM.mov
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695709767898199
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d1b259b2d9260fc0
- Upwork Job ID: 1707070231351926784
- Last Price Increase: 2023-09-27
- Automatic offers:
- s77rt | Reviewer | 26983371
- gadhiyamanan | Reporter | 26983373
Activity
[-]DEV: Chat - Error appears on click of notification and does not redirect to page[/-][+][$500] DEV: Chat - Error appears on click of notification and does not redirect to page[/+]melvin-bot commentedon Sep 27, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01d1b259b2d9260fc0
melvin-bot commentedon Sep 27, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (
External)carlosalmonte04 commentedon Sep 27, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Error shows in console after tapping notification and does not navigate as expected.
What is the root cause of that problem?
The notification is using a function that is no longer there.
What changes do you think we should make in order to solve the problem?
The function was moved from
ROUTES.getReportRoute(reportID)toROUTES.REPORT_WITH_ID.getRoute(reportID)App/src/libs/actions/Report.js
Lines 1652 to 1656 in 13b2291
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Charan-hs commentedon Sep 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
DEV: Chat - Error appears on click of notification and does not redirect to page
What is the root cause of that problem?
This is a regression from this PR #28050
In this PR refactored
ROUTES.tshere and failed to update hereApp/src/libs/actions/Report.js
Line 1686 in bfda42d
What changes do you think we should make in order to solve the problem?
just we have to update here
App/src/libs/actions/Report.js
Line 1686 in bfda42d
like this
What alternative solutions did you explore? (Optional)
jakub-trzebiatowski commentedon Sep 29, 2023
@redpanda-bit
I'm having trouble understanding what's the proposed solution. Could you try rephrasing it?
carlosalmonte04 commentedon Sep 29, 2023
TL;DR: The function
ROUTES.getReportRoute(reportID)no longer exists and the function calls to this function need to be updated toROUTES.REPORT_WITH_ID.getRoute(reportID)Thanks for asking for clarification!
It's pretty much the same as @Charan-hs 's proposal. I just had the changes (
from->to) backwards because of rushing to be the first proposal. I think both proposals achieve the exact same result.carlosalmonte04 commentedon Sep 29, 2023
Proposal
Updated
59 remaining items
flaviadefaria commentedon Oct 11, 2023
Payment Summary:
@s77rt requires - $500 - 50%(regression) = $250
@redpanda-bit - $500 - 50%(regression) = $250
@gadhiyamana - $50 (reporter)
s77rt commentedon Oct 11, 2023
@flaviadefaria This did not cause a regression (it was a regression from another PR). No penalties here.
flaviadefaria commentedon Oct 12, 2023
Thanks @s77rt, here's the updated Payment Summary:
For reference, here are some details about the assignees on this issue:
@s77rt requires payment offer (Reviewer)
@redpanda-bit requires payment
@gadhiyamanan requires payment offer (Reporter)
@s77rt requires - $500
@redpanda-bit - $500
@gadhiyamana - $50 (reporter)
Issuing payment now.
flaviadefaria commentedon Oct 12, 2023
@s77rt requires - offer sent
@redpanda-bit - please share your UW profile link since I can't find you to send an offer
@gadhiyamana - $50 (reporter) - paid
carlosalmonte04 commentedon Oct 12, 2023
@flaviadefaria here it is https://www.upwork.com/freelancers/~010e9950f7b5f0f0eb.
flaviadefaria commentedon Oct 12, 2023
@redpanda-bit offer sent!
flaviadefaria commentedon Oct 12, 2023
@s77rt requires - offer sent
@redpanda-bit - paid
@gadhiyamana - paid
@s77rt please accept the offer so that I can pay you and close this GH.
s77rt commentedon Oct 12, 2023
@flaviadefaria No payment is due for me here. Just wanted to resolve the deploy blocker. This can be closed.
flaviadefaria commentedon Oct 12, 2023
Ah, thanks for clarifying - closing!