Repository navigation
Edit comment - Spaces are not displayed in edit box #2847
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
Spaces should be visible in edit comment box
Actual Result:
Spaces are not visible in edit comment box.
Action Performed:
- Navigate to a conversation
- Send a message with the following text
Hello
Space
Test
- Right click on the message and click edit comment.
Workaround:
N/a
Platform:
Where is this issue occurring?
Web ✔️
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.43-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL: https://www.upwork.com/jobs/~01aab2d470107fe14c
From @roryabraham https://expensify.slack.com/archives/C01GTK53T8Q/p1620849222131700
When editing a comment, newlines do not appear in the text box.
Activity
MelvinBot commentedon May 13, 2021
Triggered auto assignment to @zanyrenney (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon May 13, 2021
Triggered auto assignment to @stitesExpensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.stitesExpensify commentedon May 14, 2021
@roryabraham this can probably be external unless you're working on it already, right?
roryabraham commentedon May 14, 2021
Yep I'm not working on this, so let's get this on Upwork!
MelvinBot commentedon May 14, 2021
Triggered auto assignment to @NicMendonca (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.NicMendonca commentedon May 14, 2021
Created job in Upwork: https://www.upwork.com/jobs/~01aab2d470107fe14c
25 remaining items
roryabraham commentedon May 21, 2021
Created a tracking issue for other HTML ---> MD conversions here
NicMendonca commentedon May 26, 2021
hey @pranshuchittora! how are you getting on with the PR? Is there anything you need help with?
pranshuchittora commentedon May 26, 2021
Hi @NicMendonca I am working on it but the version of
expensify-commonon GitHub is1.0.0but on npm it's1.0.1.https://github.com/Expensify/expensify-common/blob/f9156da06752046c1df8a32461e46fb51684b32d/package.json#L3
https://www.npmjs.com/package/expensify-common
pranshuchittora commentedon May 26, 2021
Thought @roryabraham @marcaaron
Peek.2021-05-27.01-12.mp4
Current Implementation
As of now, there's only one rule for HTML -> Markdown. Which parses and modifies the string
Future Architecture
We can have a set of pre and post rules as we have now. for text parser.
Blockers
Version of
expensify-commonon GitHub is1.0.0but on npm it's1.0.1.https://github.com/Expensify/expensify-common/blob/f9156da06752046c1df8a32461e46fb51684b32d/package.json#L3
https://www.npmjs.com/package/expensify-common
roryabraham commentedon May 26, 2021
Until recently, we were pointing Expensify.cash at an expensify-common commit hash rather than actually publishing expensify-common on npm. It looks like @jasperhuangg changed that here.
@marcaaron since you wrote the SO that @jasperhuangg references in that PR, do you have any comment on whether or not we should be publishing expensify-common on NPM vs just using a commit hash?
tgolen commentedon May 26, 2021
The SO that Jasper linked to is a very general SO that was written with the context of web-e, web-s, and mobile. It wasn't really meant to cover e.cash. @AndrewGable talked about this a lot in the beginning and I think our takeaway was:
At the time, there were doubts if we could maintain the strict control we needed, which is why we used the hash. Here is the full context behind it: https://github.com/Expensify/Expensify/issues/147306 and it looks like the concern was never resolved.
tgolen commentedon May 26, 2021
I think we should revert Jasper's change until the solution recommended in that linked issue is solved.
roryabraham commentedon May 26, 2021
Agreed @tgolen.
So @pranshuchittora your process should probably be something like this:
marcaaron commentedon May 26, 2021
That SO is out of date and should be deleted. I wrote those instructions thinking we would adopt that plan (we didn't) and then went OOO and it slipped my mind. Amending it now, but we should revert @jasperhuangg's changes.
marcaaron commentedon May 26, 2021
Sorry, I've updated those instructions so we can avoid this in the future.
jasperhuangg commentedon May 27, 2021
Hey! Sorry for missing this. I wasn't aware that there was a difference, apologies for failing to notice this. I guess something felt slightly off when it was startimg off at version 1.0.0, but I didn't think much of it. Glad you were able to revert the change!
pranshuchittora commentedon May 27, 2021
To summarise
expensify-common.expensify-commonto the merge commit hash inE.cashrepo (this repo).Is this correct?
cc @jasperhuangg @marcaaron