Web - Wallet Statement Modal - Statement is not displayed and errors appear

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #27934

Action Performed:

Login to staging.new.expensify.com
Go to staging.new.expensify.com/statements/202308
Check the modal and console in local environment

Expected Result:

There should be no error in the console in local environment

Actual Result:

"Refused to connect" message is displayed and error in the console in local environment shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219063_1695993762752.Recording__1121.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e92423cfeff9e754
Upwork Job ID: 1708417503606587392
Last Price Increase: 2023-10-01

@adelekennedy

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@AndrewGable

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Issue is still repro it on latest build v1.3.75-3 on Windows 10/Chrome

restest1.mp4

Job added to Upwork: https://www.upwork.com/jobs/~01e92423cfeff9e754

@eVoloshchak

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

Coming from this Slack convo https://expensify.slack.com/archives/C02NK2DQWUX/p1696148431657419 it seems like this is not coming from the App but more so from internal changes but the statement should work fine in production so going to remove the deploy blocker label

On production, the wallet statement page is displayed without any issue

On the other note, links in the iframe seem not be working:

Screen.Recording.2023-09-29.at.2.32.11.PM.mov

@AndrewGable

@AndrewGable @mountiny
This is my suggestion

Root cause

NewDot embeds an OldDot page (wallet statement page) inside an iframe of NewDot.
Both production and staging NewDots embed production OldDot.
This means that when on staging, staging.new.expensify.com embeds www.expensify.com.
These websites are considered as separate websites by the browser.
Because current production OldDot CSP header doesn't explicitly list staging.new.expensify.com under frame-ancestors, the browser denies to display production OldDot inside the staging NewDot.

Solution

Let's embed the staging OldDot when NewDot is the staging one.
Let's modify the CSP of staging OldDot so that the staging NewDot can embed it. (this one will be handled here anyway)

@hayata-suenaga

@hayata-suenaga I have confirmed with the QA they normally dont test this so its not a new issue. I think that this will eventually be handled by the changes required for the hybrid web so I think we dont have to do anything specific here and changes made for the hybrid web will fix this too.

Hence I think we can close this issue, feel free to reopen if you disgree

Navigation Menu

Repository navigation

Web - Wallet Statement Modal - Statement is not displayed and errors appear #28490

Action Performed:

Expected Result:

Actual Result:

Workaround: