Skip to content

iOS - SMS - Code is changed when select it in autofill #28494

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch App
  2. Enter SMS account
  3. Tap on the suggestion with the code received from messages

Expected Result:

Code fill out and sms account sign in

Actual Result:

Code is changed when select it in autofill

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219107_1695996826355.RPReplay_Final1695939724.mp4

Bug6219107_1695996826378!3

Bug6219107_1695996826378!3 (1)

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 29, 2023
  2. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 29, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. lanitochka17 commented on Sep 29, 2023

    @lanitochka17
    Author

    Issue reproduced on build 1.3.75.3 on iPhone 14 Pro/ 17.0.2

    RPReplay_Final1696009618.MP4
  7. situchan commented on Sep 29, 2023

    @situchan
    Contributor

    I suspect this came from #24012 as it's only the recent change related to magic code input.

  8. wojtus7 commented on Sep 30, 2023

    @wojtus7
    Contributor

    Hi! I'am the creator of the Magic Code PR mentioned above and tried to repro the issue and fix it but my phone number doesn't seem to work. Do you know any workaround that would help me fix it?

    image

  9. mountiny commented on Oct 1, 2023

    @mountiny
    Contributor

    @wojtus7 because this is a deploy blocker, should we consider reverting the PR given this is harder to test.

    I think is the staging/ production backend env you just need to have real phone number

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 2, 2023
  11. mountiny commented on Oct 2, 2023

    @mountiny
    Contributor
  12. added
    ReviewingHas a PR in review
    and removed on Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions