Skip to content

[HOLD 2023-10-16] [$125] mweb/Safari - Composer - Cursor does not moved to a new line in the composer when tapped on the "return" #28501

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #27490

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Tap on any listed conversation in LHN
  3. Tap on the composer box
  4. Write any words
  5. Tap on the "return" button on keayboard

Expected Result:

Cursor should be moved to a new line

Actual Result:

Nothing happened. The cursor remains on the same line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219214_1696001683570.RPReplay_Final1696001647.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a307034471edf3f5
  • Upwork Job ID: 1713885684306395136
  • Last Price Increase: 2023-10-16

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 29, 2023
  2. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 29, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. lanitochka17 commented on Sep 29, 2023

    @lanitochka17
    Author

    The issue is not reproducible with a 1.3.75.3 build

    RPReplay_Final1696009728.mp4
  7. chiragsalian commented on Sep 29, 2023

    @chiragsalian
    Contributor

    i cannot reproduce either, closing issue.

  8. 26 remaining items

  9. melvin-bot commented on Oct 12, 2023

    @melvin-bot

    @trjExpensify, @mountiny, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. trjExpensify commented on Oct 13, 2023

    @trjExpensify
    Contributor

    What's the dealio here? We're ready to pay @bernhardoj $125 for this?

  11. changed the title [-][$125] mweb/Safari - Composer - Cursor does not moved to a new line in the composer when tapped on the "return"[/-] [+][HOLD 2023-10-16] [$125] mweb/Safari - Composer - Cursor does not moved to a new line in the composer when tapped on the "return"[/+] on Oct 15, 2023
  12. mountiny commented on Oct 15, 2023

    @mountiny
    Contributor

    Yep I think we are good to pay, the checklist is not needed I think, it was already clearly identified what pr was this regression from and the author has addressed it using fix provided by @bernhardoj

  13. added
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 16, 2023
  14. melvin-bot commented on Oct 16, 2023

    @melvin-bot
  15. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

  16. trjExpensify commented on Oct 16, 2023

    @trjExpensify
    Contributor

    (needed a job created in Upwork, removing @situchan).

  17. trjExpensify commented on Oct 16, 2023

    @trjExpensify
    Contributor

    @bernhardoj sent you an offer for $125!

  18. bernhardoj commented on Oct 16, 2023

    @bernhardoj
    Contributor

    Thanks! Accepted. @trjExpensify

  19. trjExpensify commented on Oct 16, 2023

    @trjExpensify
    Contributor

    Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions