You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [$125] Task - When the receiver clicks on a task, "Hmm... it's not here" is displayed briefly #28508
Open another browser and log in to User B's account.
Open User A's chat and open the task.
Expected Result:
When the receiver clicks on the task, "Hmm... it's not here" should not be displayed
Actual Result:
When the receiver clicks on the task, "Hmm... it's not here" is displayed briefly
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.75.2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When the receiver clicks on a task, "Hmm... it's not here" is displayed briefly.
What is the root cause of that problem?
In the ReportScreen, the report prop does not immediately update when the navigation changes. Consequently, when the recipient clicks on a task, report.reportID becomes undefined, causing shouldShowNotFoundPage to be true and displaying the 'Hmm... it's not here.
What changes do you think we should make in order to solve the problem?
But here we use report.isLoadingReportActions to check whether the report action is loading or not. So the check is wrong and not found page is displayed briefly
We should set the default for isLoadingReportActions here as true because when we open the new report, reportMedata doesn't exist before it's merged in Onyx.
And here, we should check the report exists in Onyx but reportActions is empty we will call openReport API to get the reportActions and update isLoadingReportActions to false
And here, we should check the report exists in Onyx but reportActions is empty we will call openReport API to get the reportActions and update isLoadingReportActions to false
Why this change is needed? is it possible that we have an existing report without report actions?
Edit: It's possible as openApp command doesn’t include all reports actions collection.
Why this change is needed? is it possible that we have an existing report without report actions?
@fedirjh Let's imagine this case that is after signing out and signing again, we open a report in LHN, the report data exists but doesn't have any report actions, and openReport API isn't called with this condition and then the page will load infinitely
It was not necessary before because in the past ReportActionView was rendered briefly and in this component, we always call openReport API when it's mounted. But with my proposal, the skeleton will be displayed until the openReport API is called in ReportScreen. So this check above is necessary.
Activity
OSBotify commentedon Sep 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.astrohunter62 commentedon Sep 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When the receiver clicks on a task, "Hmm... it's not here" is displayed briefly.
What is the root cause of that problem?
In the
ReportScreen, thereportprop does not immediately update when the navigation changes. Consequently, when the recipient clicks on a task,report.reportIDbecomes undefined, causingshouldShowNotFoundPageto be true and displaying the 'Hmm... it's not here.What changes do you think we should make in order to solve the problem?
We can use the currentReportID props.
For example:
Result:
28508.Chrome.webm
28508.Safari.webm
dukenv0307 commentedon Sep 30, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Task - When the receiver clicks on a task, "Hmm... it's not here" is displayed briefly
What is the root cause of that problem?
We move
isLoadingReportActionstoreportMetaDataand inopenReportAPI, we set it astrueinreportMetaDataApp/src/libs/actions/Report.js
Lines 463 to 467 in 52f0e3c
But here we use
report.isLoadingReportActionsto check whether the report action is loading or not. So the check is wrong and not found page is displayed brieflyApp/src/pages/home/ReportScreen.js
Line 373 in 52f0e3c
What changes do you think we should make in order to solve the problem?
We should replace
report.isLoadingReportActionswithreportMetaData.isLoadingReportActionsto check whether the report action is loading or notApp/src/pages/home/ReportScreen.js
Line 373 in 52f0e3c
We should set the default for
isLoadingReportActionshere astruebecause when we open the new report,reportMedatadoesn't exist before it's merged in Onyx.App/src/pages/home/ReportScreen.js
Lines 107 to 109 in 52f0e3c
App/src/pages/home/ReportScreen.js
Line 489 in 52f0e3c
And here, we should check the report exists in Onyx but
reportActionsis empty we will callopenReportAPI to get the reportActions and updateisLoadingReportActionstofalseApp/src/pages/home/ReportScreen.js
Line 251 in 52f0e3c
What alternative solutions did you explore? (Optional)
NA
Result
Screencast.from.30-09-2023.14.23.16.webm
mountiny commentedon Oct 1, 2023
the proposal from @dukenv0307 sounds good to me! @ospfranco @fedirjh what do you think?
fedirjh commentedon Oct 1, 2023
Why this change is needed? is it possible that we have an existing report without report actions?
Edit: It's possible as
openAppcommand doesn’t include all reports actions collection.mountiny commentedon Oct 1, 2023
We only return the report actions for parent threads with the parent report actions
dukenv0307 commentedon Oct 1, 2023
@fedirjh Let's imagine this case that is after signing out and signing again, we open a report in LHN, the report data exists but doesn't have any report actions, and
openReportAPI isn't called with this condition and then the page will load infinitelyApp/src/pages/home/ReportScreen.js
Lines 251 to 252 in 52f0e3c
It was not necessary before because in the past
ReportActionViewwas rendered briefly and in this component, we always callopenReportAPI when it's mounted. But with my proposal, the skeleton will be displayed until theopenReportAPI is called inReportScreen. So this check above is necessary.App/src/pages/home/report/ReportActionsView.js
Lines 83 to 95 in 00933e1
fedirjh commentedon Oct 1, 2023
Thanks @dukenv0307 that makes sense to me.
cc @mountiny the proposal looks good to me.
ospfranco commentedon Oct 2, 2023
@dukenv0307 LGTM
60 remaining items
melvin-bot commentedon Oct 23, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 23, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)mountiny commentedon Oct 23, 2023
@trjExpensify could you please help me process the payments here #28508 (comment) thanks!
trjExpensify commentedon Oct 23, 2023
as per here, confirming payments as follows:
$50 to @ayazhussain79 for the bug report and $125 to @dukenv0307 for the proposal.
@dukenv0307 has been paid. @ayazhussain79 i've sent you an offer.
ayazhussain79 commentedon Oct 23, 2023
@trjExpensify offer accepted, Thank you
trjExpensify commentedon Oct 23, 2023
Paid.
kevinksullivan commentedon Oct 25, 2023
Sorry for missing this one guys. And thanks @trjExpensify !