Skip to content

[HOLD for payment 2023-10-12] [$500] Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page #28515

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login to ND
  2. Click on FAB > Request Money > Manual tab
  3. Enter '0' if not already there in the amount
  4. Click on Next

Expected Result:

The gap between the error messages is consistent, just like on other pages, such as Home Address, Legal Name, Date of Birth, etc

Actual Result:

The gap is much larger than the gap between error message and CTA button on any other page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshot 2023-09-29 at 9 19 02 PM
Screenshot 2023-09-29 at 4 25 04 AM

Recording.4803.mp4

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695942566946709

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c93d7659514ccde7
  • Upwork Job ID: 1707802938882224128
  • Last Price Increase: 2023-09-29
  • Automatic offers:
    • aman-atg | Contributor | 26975517
    • aman-atg | Reporter | 26975520

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 29, 2023
  2. changed the title [-]Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page[/-] [+][$500] Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page[/+] on Sep 29, 2023
  3. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Sep 29, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 29, 2023
  6. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  8. kbecciv commented on Sep 29, 2023

    @kbecciv
    Author

    Proposal by: @aman-atg
    Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695942566946709

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The gap between error message and 'Next' button is much larger for Request Money's Manual Page

    What is the root cause of that problem?

    We are using styles.mt5 here which works for platforms where BigNumberPad component is visible but for other platforms this much gap is unnecessary. And FormHelpMessage itself has marginBottom values which further increases the gap between the error message and the button.

    What changes do you think we should make in order to solve the problem?

    We can define a variable like canUseTouchScreen and use it to determine which value to use for the top margin.

    Example:

     
                    {canUseTouchScreen ? (
                        <BigNumberPad
                          // ...other props
                        />
                    ) : null}
                    <Button
                        // ...other props
                        style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt2]}
                    />

    Here, I've used styles.mt2 but we can use any other value as well as per design team's suggestion.
    With this, the total gap between will be 12px, considering styles.mt2 from the Button and styles.mb1 from the FormHelpMessage

    What alternative solutions did you explore? (Optional)

    We can use various margin spacing combinations for the FormHelpMessage and Button components, such as using styles.mb0 and styles.mt3 respectively when canUseTouchScreen is false.

    However, changing FormHelpMessage's style will also have an effect when canUseTouchScreen is true and BigNumberPad is visible so it needs to be validated by the design team if we choose to do so.

  9. saranshbalyan-1234 commented on Sep 29, 2023

    @saranshbalyan-1234
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Error message have different space in some places

    What is the root cause of that problem?

    Due to extra styles passed as props, we are getting this error.

    What changes do you think we should make in order to solve the problem?

    {DeviceCapabilities.canUseTouchScreen() ? (
    <BigNumberPad
    nativeID={NUM_PAD_VIEW_ID}
    numberPressed={updateAmountNumberPad}
    longPressHandlerStateChanged={updateLongPressHandlerState}
    />
    ) : null}
    <Button
    success
    medium={isExtraSmallScreenHeight}
    style={[styles.w100, styles.mt5]}
    onPress={submitAndNavigateToNextPage}
    pressOnEnter
    text={buttonText}
    />

    Just need to replace mt5 with mt3 like this

      <Button
                        success
                        medium={isExtraSmallScreenHeight}
                        style={[styles.w100, styles.mt2]}
                        onPress={submitAndNavigateToNextPage}
                        pressOnEnter
                        text={buttonText}
                    />

    no need to change it with respect to devices as there is already a condition based on DeviceCapabilities.canUseTouchScreen() on top

    What alternative solutions did you explore? (Optional)

    N/A

  10. allroundexperts commented on Oct 1, 2023

    @allroundexperts
    Contributor

    @aman-atg's proposal looks good to me. I think we need to reduce the margin only if the number pad is not visible.

    🎀 👀 🎀 C+ reviewed

  11. 21 remaining items

  12. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts] Determine if we should create a regression test for this bug.
    • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. flaviadefaria commented on Oct 12, 2023

    @flaviadefaria
    Contributor

    @allroundexperts can you please respond to the above comment so that I can issue payment? Thanks!

  14. flaviadefaria commented on Oct 16, 2023

    @flaviadefaria
    Contributor

    Bump @allroundexperts I'm no longer in BZ team but should action this as it was due last week. Thanks!

  15. flaviadefaria commented on Oct 16, 2023

    @flaviadefaria
    Contributor

    Payment Summary:

    For reference, here are some details about the assignees on this issue:
    @aman-atg requires payment offer (Contributor)
    @allroundexperts does not require payment (Eligible for Manual Requests)
    @aman-atg requires payment offer (Contributor)

    @aman-atg - $500 + $250 (50% bonus) + $50 (reporting bonus) = $800
    @allroundexperts - $500 + $250 (50% bonus) = $750

  16. allroundexperts commented on Oct 17, 2023

    @allroundexperts
    Contributor

    Checklist

    1. Refactor/23149 money request page #23979
    2. https://github.com/Expensify/App/pull/23979/files#diff-220bddc002da5d59f03021bfe9beee13459ae566577867fde837f7f14cf4717eR245
    3. I think this was a minor design issue and a Slack discussion is not needed here.
    4. A regression test again would be an overkill since this is a small design in-consistency.
  17. allroundexperts commented on Oct 17, 2023

    @allroundexperts
    Contributor

    @flaviadefaria I think the amount should be $850 for @aman-atg. As per @NicMendonca, we give a bonus of $50 if someone reports and fix his own bug!

  18. flaviadefaria commented on Oct 18, 2023

    @flaviadefaria
    Contributor

    @allroundexperts, @NicMendonca misinterpreted the internal documentation - we just clarified this internally. There's no additional bonus for reporting and fixing their own bug. They simply get paid the reporting bonus on top of what they get for fixing the bug. So $800 is the correct amount.

  19. allroundexperts commented on Oct 18, 2023

    @allroundexperts
    Contributor

    Oh. Got it @flaviadefaria. Thanks for the clarification!

  20. flaviadefaria commented on Oct 18, 2023

    @flaviadefaria
    Contributor

    @aman-atg you've been paid so closing this GH.

  21. JmillsExpensify commented on Oct 18, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @allroundexperts based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions