You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-12] [$500] Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page #28515
The gap between the error messages is consistent, just like on other pages, such as Home Address, Legal Name, Date of Birth, etc
Actual Result:
The gap is much larger than the gap between error message and CTA button on any other page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.75.2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page[/-][+][$500] Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page[/+]on Sep 29, 2023
Please re-state the problem that we are trying to solve in this issue.
The gap between error message and 'Next' button is much larger for Request Money's Manual Page
What is the root cause of that problem?
We are using styles.mt5here which works for platforms where BigNumberPad component is visible but for other platforms this much gap is unnecessary. And FormHelpMessage itself has marginBottom values which further increases the gap between the error message and the button.
What changes do you think we should make in order to solve the problem?
We can define a variable like canUseTouchScreen and use it to determine which value to use for the top margin.
Here, I've used styles.mt2 but we can use any other value as well as per design team's suggestion.
With this, the total gap between will be 12px, considering styles.mt2 from the Button and styles.mb1 from the FormHelpMessage
What alternative solutions did you explore? (Optional)
We can use various margin spacing combinations for the FormHelpMessage and Button components, such as using styles.mb0 and styles.mt3 respectively when canUseTouchScreen is false.
However, changing FormHelpMessage's style will also have an effect when canUseTouchScreen is true and BigNumberPad is visible so it needs to be validated by the design team if we choose to do so.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
For reference, here are some details about the assignees on this issue: @aman-atg requires payment offer (Contributor) @allroundexperts does not require payment (Eligible for Manual Requests) @aman-atg requires payment offer (Contributor)
@allroundexperts, @NicMendonca misinterpreted the internal documentation - we just clarified this internally. There's no additional bonus for reporting and fixing their own bug. They simply get paid the reporting bonus on top of what they get for fixing the bug. So $800 is the correct amount.
Activity
[-]Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page[/-][+][$500] Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page[/+]melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @flaviadefaria (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 29, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c93d7659514ccde7
melvin-bot commentedon Sep 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)kbecciv commentedon Sep 29, 2023
Proposal by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695942566946709
Proposal
Please re-state the problem that we are trying to solve in this issue.
The gap between error message and 'Next' button is much larger for Request Money's Manual Page
What is the root cause of that problem?
We are using
styles.mt5here which works for platforms whereBigNumberPadcomponent is visible but for other platforms this much gap is unnecessary. AndFormHelpMessageitself has marginBottom values which further increases the gap between the error message and the button.What changes do you think we should make in order to solve the problem?
We can define a variable like
canUseTouchScreenand use it to determine which value to use for the top margin.Example:
{canUseTouchScreen ? ( <BigNumberPad // ...other props /> ) : null} <Button // ...other props style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt2]} />Here, I've used
styles.mt2but we can use any other value as well as per design team's suggestion.With this, the total gap between will be 12px, considering
styles.mt2from the Button and styles.mb1 from theFormHelpMessageWhat alternative solutions did you explore? (Optional)
We can use various margin spacing combinations for the
FormHelpMessageandButtoncomponents, such as usingstyles.mb0andstyles.mt3respectively whencanUseTouchScreenis false.However, changing FormHelpMessage's style will also have an effect when
canUseTouchScreenis true and BigNumberPad is visible so it needs to be validated by the design team if we choose to do so.saranshbalyan-1234 commentedon Sep 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Error message have different space in some places
What is the root cause of that problem?
Due to extra styles passed as props, we are getting this error.
What changes do you think we should make in order to solve the problem?
App/src/pages/iou/steps/MoneyRequestAmountForm.js
Lines 260 to 274 in 67d4a7a
Just need to replace mt5 with mt3 like this
no need to change it with respect to devices as there is already a condition based on DeviceCapabilities.canUseTouchScreen() on top
What alternative solutions did you explore? (Optional)
N/A
allroundexperts commentedon Oct 1, 2023
@aman-atg's proposal looks good to me. I think we need to reduce the margin only if the number pad is not visible.
🎀 👀 🎀 C+ reviewed
21 remaining items
melvin-bot commentedon Oct 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
flaviadefaria commentedon Oct 12, 2023
@allroundexperts can you please respond to the above comment so that I can issue payment? Thanks!
flaviadefaria commentedon Oct 16, 2023
Bump @allroundexperts I'm no longer in BZ team but should action this as it was due last week. Thanks!
flaviadefaria commentedon Oct 16, 2023
Payment Summary:
@aman-atg - $500 + $250 (50% bonus) + $50 (reporting bonus) = $800
@allroundexperts - $500 + $250 (50% bonus) = $750
allroundexperts commentedon Oct 17, 2023
Checklist
allroundexperts commentedon Oct 17, 2023
@flaviadefaria I think the amount should be $850 for @aman-atg. As per @NicMendonca, we give a bonus of $50 if someone reports and fix his own bug!
flaviadefaria commentedon Oct 18, 2023
@allroundexperts, @NicMendonca misinterpreted the internal documentation - we just clarified this internally. There's no additional bonus for reporting and fixing their own bug. They simply get paid the reporting bonus on top of what they get for fixing the bug. So $800 is the correct amount.
allroundexperts commentedon Oct 18, 2023
Oh. Got it @flaviadefaria. Thanks for the clarification!
flaviadefaria commentedon Oct 18, 2023
@aman-atg you've been paid so closing this GH.
JmillsExpensify commentedon Oct 18, 2023
$750 payment approved for @allroundexperts based on BZ summary.