[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker

@dhanashree-sawant

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Right click or long press any report and click on add reaction
Observe that it does nothing and throws console error: Cannot read properties of undefined (reading 'current')

Expected Result:

App should allow users to open emoji picker for reaction

Actual Result:

App does not allow users to open emoji picker for reaction on right click and click on add reaction and it throws console error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

mac.chrome.error.on.opening.emoji.reaction.mov

mac.desktop.native.error.on.opening.emoji.reaction.mov

ios.safari.native.error.on.opening.emoji.reaction.mov

android.native.emoji.picker.console.error.mov

android.chrome.console.error.emoji.picker.mp4

windows.chrome.console.error.emoji.picker.mp4

Recording.4810.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696079858252189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0103f61623015d853c
Upwork Job ID: 1708383767969234944
Last Price Increase: 2023-10-01
Automatic offers:

abdulrahuman5196 | Contributor | 26964631
dhanashree-sawant | Reporter | 26964632
hungvu193 | Contributor | 26982014

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@johnmlee101

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after pressing Icon to open emoji picker

What is the root cause of that problem?

It's regression from this PR
#27221
We forgot to add our contentRef to useImperativeHandle, so we can't access it via contextMenuRef.current.contentRef which caused the crash

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 272 to 281 in 52f0e3c

    
           useImperativeHandle(ref, () => ({ 
        
               showContextMenu, 
        
               hideContextMenu, 
        
               showDeleteModal, 
        
               hideDeleteModal, 
        
               isActiveReportAction, 
        
               instanceID, 
        
               runAndResetOnPopoverHide, 
        
               clearActiveReportAction, 
        
           }));

What changes do you think we should make in order to solve the problem?

We should add contentRef inside useImperativeHandle

    useImperativeHandle(ref, () => ({
        showContextMenu,
        hideContextMenu,
        showDeleteModal,
        hideDeleteModal,
        isActiveReportAction,
        instanceID,
        runAndResetOnPopoverHide,
        clearActiveReportAction,
        contentRef
    }));

What alternative solutions did you explore? (Optional)

N/A

@hungvu193

@hungvu193 Proposal makes sense, this is a regression from #27221.

Job added to Upwork: https://www.upwork.com/jobs/~0103f61623015d853c

@hungvu193

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP-Staging]:fix crash while opening emoji picker #28558

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment offer (Contributor)
@abdulrahuman5196 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@abdulrahuman5196

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@hungvu193

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP-Staging]:fix crash while opening emoji picker #28558

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment offer (Contributor)
@abdulrahuman5196 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@abdulrahuman5196

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@abdulrahuman5196

@abdulrahuman5196 friendly reminder on the checklist.

@puneetlath

The PR that introduced the bug has been identified. Link to the PR:

#27221

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/27221/files#r1350610872

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Its a minor bug and won't be benificial to add regression test.

cc: @puneetlath

All paid. Thanks everyone!

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

32 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	useImperativeHandle(ref, () => ({
	showContextMenu,
	hideContextMenu,
	showDeleteModal,
	hideDeleteModal,
	isActiveReportAction,
	instanceID,
	runAndResetOnPopoverHide,
	clearActiveReportAction,
	}));

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

OSBotify commented on Sep 30, 2023

melvin-bot commented on Sep 30, 2023

hungvu193 commented on Sep 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

fedirjh commented on Sep 30, 2023

melvin-bot commented on Oct 1, 2023

32 remaining items

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 3, 2023

melvin-bot commented on Oct 3, 2023

puneetlath commented on Oct 9, 2023

abdulrahuman5196 commented on Oct 9, 2023

puneetlath commented on Oct 11, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions