You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Profile - Contact method - App does not refocus to magic code on canceling contact method remove #28590
changed the title [-]Profile - Contact method - App does not refocus to magic code on canceling contact method remove[/-][+][$500] Profile - Contact method - App does not refocus to magic code on canceling contact method remove[/+]on Oct 2, 2023
Activity
[-]Profile - Contact method - App does not refocus to magic code on canceling contact method remove[/-][+][$500] Profile - Contact method - App does not refocus to magic code on canceling contact method remove[/+]melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to @peterdbarkerUK (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 2, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01acef7fd06fbd423e
melvin-bot commentedon Oct 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)izarutskaya commentedon Oct 2, 2023
Not reproduced on Production
Recording.1679.mp4
saranshbalyan-1234 commentedon Oct 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App does not refocus to magic code on canceling contact method remove
What is the root cause of that problem?
Focus method is not called here
App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js
Lines 209 to 212 in 052f23d
What changes do you think we should make in order to solve the problem?
Need go call focus method with setTimeout
Setimeout is required as page is currently re-rendering while modal is being closed.
What alternative solutions did you explore? (Optional)
N/A
dukenv0307 commentedon Oct 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Profile - Contact method - App does not refocus to magic code on canceling contact method remove
What is the root cause of that problem?
We don't have the logic to refocus the input when the confirm modal is closed
App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js
Lines 261 to 268 in 052f23d
What changes do you think we should make in order to solve the problem?
We should add
onModalHideprop forConfirmModalthat will be triggered after the modal is closed to refocus the inputApp/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js
Lines 261 to 268 in 052f23d
What alternative solutions did you explore? (Optional)
NA
Result
Screencast.from.02-10-2023.16.47.48.webm
9 remaining items
mountiny commentedon Oct 2, 2023
The PR was reverted and this is not a blcoker anymore https://expensify.slack.com/archives/C9YU7BX5M/p1696260504107759?thread_ts=1696257638.565279&cid=C9YU7BX5M
I believe the only pending thing here @peterdbarkerUK is to pay $50 to @dhanashree-sawant for reporting this blocker
peterdbarkerUK commentedon Oct 6, 2023
Offer sent @dhanashree-sawant
dhanashree-sawant commentedon Oct 6, 2023
Thanks @peterdbarkerUK, I have accepted the offer.
peterdbarkerUK commentedon Oct 6, 2023
Sweet
Reporter: $50 paid to @dhanashree-sawant
Thanks for your continued prolific work @dhanashree-sawant!