[$500] Login - App displays half or no animation on login with suspended email on mWeb

@dhanashree-sawant

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
If login then logout
Enter any suspended email eg: bhansalidhruval+email4@gmail.com
Continue and observe that in mWeb, animation below text is either displayed partially or not displayed at all

Expected Result:

App should display login page animation below suspended email text as it does on native apps

Actual Result:

App either displays half or no animation below suspended email text on login

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.75-8

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

android.chrome.half.animation.on.login.with.suspended.email.mp4

ios.native.safari.login.with.suspended.email.mov

Screen_Recording_20231001_192352_Chrome.mp4

Rpreplay.Final1696240886.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696070722641579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015ad25d04cd0c007c
Upwork Job ID: 1708785780120797184
Last Price Increase: 2023-10-16

Job added to Upwork: https://www.upwork.com/jobs/~015ad25d04cd0c007c

@maddylewis

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mollfpr

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

Proposal

Problem

App displays half or no animation on login with suspended email on mWeb

Root cause

This happens because on smallscreen device we have set the flex1 for parent container of the sign in content that limits the container to its min-height.

Changes

We can safely remove the flex1 from the styles here.

Alternatively

We can increase the minHeight to a larger number when there is a suspended email error, we'll use a prop shouldShowEmailDeliveryFailurePage passed from upstream component to SignInPageLayout and use a different variable for container minHeight can be decided by design team.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App displays half or no animation on login with suspended email on mWeb

What is the root cause of that problem?

The cause of issue is that we have style.flex1 and minHeight together.
So we get half image on web and no image on mWeb.

What changes do you think we should make in order to solve the problem?

We need to remove style.flex1 and style.flexColumn from

App/src/pages/signin/SignInPageLayout/index.js

Line 156 in 3e9fdf6

    
           <View style={[styles.flex1, styles.flexColumn, styles.overflowHidden, StyleUtils.getMinimumHeight(Math.max(variables.signInContentMinHeight, containerHeight))]}>

What alternative solutions did you explore? (Optional)

@ishpaul777

@ishpaul777 @yh-0218 Why it's working fine on native app?

@ishpaul777

I'm okay with the solution to remove the flex1, and @ishpaul777 is proposing it first. So, let's go with their proposal.

🎀 👀 🎀 C+ reviewed!

@maddylewis Please help with the Engineer label. Thank you!

@maddylewis

@maddylewis gentle bump

@mollfpr

@mollfpr @maddylewis this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@mollfpr

@mollfpr, @maddylewis Huh... This is 4 days overdue. Who can take care of this?

@mollfpr

@mollfpr, @maddylewis Still overdue 6 days?! Let's take care of this!

@maddylewis

Friendly bump @maddylewis to re-add the engineering label.

@mollfpr

@mollfpr Can you comment the 🎀 👀 🎀 C+ reviewed! stamp again so that melvin assign a engineer to review

@ishpaul777

@ishpaul777 It won't work because I'm not in the c+team temporarily. So Melvin doesn't recognize my comment as a c+.

We can close this as not reproducible anymore
https://expensify.slack.com/archives/C01GTK53T8Q/p1698438580870269?thread_ts=1698433995.864499&cid=C01GTK53T8Q

Navigation Menu

Repository navigation

[$500] Login - App displays half or no animation on login with suspended email on mWeb #28592

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Problem

Root cause

Changes

Alternatively

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

20 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] Login - App displays half or no animation on login with suspended email on mWeb #28592

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Oct 2, 2023

ishpaul777 commented on Oct 2, 2023

Proposal

Problem

Root cause

Changes

Alternatively

yh-0218 commented on Oct 2, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mollfpr commented on Oct 4, 2023

20 remaining items

mollfpr commented on Oct 18, 2023

ishpaul777 commented on Oct 19, 2023

melvin-bot commented on Oct 23, 2023

melvin-bot commented on Oct 23, 2023

melvin-bot commented on Oct 25, 2023

mollfpr commented on Oct 25, 2023

ishpaul777 commented on Oct 25, 2023

mollfpr commented on Oct 25, 2023

0xmiroslav commented on Oct 27, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions