[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - App crash on click of back button

@gadhiyamanan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Settings > Workspaces
Click on back button

Expected Result:

App should not crash

Actual Result:

App crash (Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev 1.3.75-8
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-02.at.1.03.28.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696231998119979

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015b1efa830b9ecb1c
Upwork Job ID: 1708892554706366464
Last Price Increase: 2023-10-02

Job added to Upwork: https://www.upwork.com/jobs/~015b1efa830b9ecb1c

@hoangzinh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

Potential deploy blocker when #27223 is deployed

@kacper-mikolajczak

This should be treated as a regression
@kacper-mikolajczak Can you fix this ASAP?

That PR caused another bad regression - #27223 (comment)
I think better to revert as it's just function component refactor.

@ArekChr

@ArekChr and @kacper-mikolajczak will handle this

@francoisl

@francoisl, @hoangzinh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@gadhiyamanan

This blocker was handled internally, so I believe we just need to compensate @gadhiyamanan for reporting the issue.

@francoisl

Thanks @francoisl
@gadhiyamanan , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~015b1efa830b9ecb1c

(d'oh, thought I was BZ here, hahahah)

@mallenexpensify

@mallenexpensify offer accepted, thanks!

@gadhiyamanan

Issue reporter: @gadhiyamanan paid $50 via Upwork

@hoangzinh can you fill out the below please, not sure why it wasn't auto-posted here.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: Hoverable component refactored from class into functional approach #27223
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Hoverable component refactored from class into functional approach #27223 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. ❌ Nope, the offending PR has been reverted.

@mallenexpensify

@mallenexpensify Oh wait. Do we still need the BZ checklist? This issue was handled internally by reverting the offending PR.

@hoangzinh

oh, I think I missed that @hoangzinh , I don't think we need the BZ checklist if we reverted the PR. Thx!

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - App crash on click of back button #28634

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

25 remaining items

Bug0 Triage Checklist (Main S/O)

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - App crash on click of back button #28634

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

MonilBhavsar commented on Oct 2, 2023

shubham1206agra commented on Oct 2, 2023

situchan commented on Oct 2, 2023

situchan commented on Oct 2, 2023

25 remaining items

melvin-bot commented on Oct 17, 2023

melvin-bot commented on Oct 17, 2023

melvin-bot commented on Oct 17, 2023

Bug0 Triage Checklist (Main S/O)

francoisl commented on Oct 17, 2023

mallenexpensify commented on Oct 18, 2023

gadhiyamanan commented on Oct 18, 2023

mallenexpensify commented on Oct 18, 2023

hoangzinh commented on Oct 19, 2023

BugZero Checklist:

hoangzinh commented on Oct 19, 2023

mallenexpensify commented on Oct 20, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions