You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment #28656
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-][+][$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+]on Oct 2, 2023
changed the title [-][$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-][+][HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+]on Oct 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-10. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-][+][HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+]on Oct 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Oct 2, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mountiny commentedon Oct 2, 2023
This seems very much related to this blocker #28654
Would reverting this PR solve it #25557? cc @situchan
[-] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-][+][$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+]18 remaining items
[-][$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-][+][HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+]melvin-bot commentedon Oct 3, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-10. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 3, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-][+][HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+]melvin-bot commentedon Oct 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
kbecciv commentedon Nov 8, 2023
Issue not reproduced on build v1.3.96-10
bandicam.2023-11-08.17-45-01-047.mp4
situchan commentedon Nov 8, 2023
@kbecciv yes, it's expected not reproducible on staging. Did you also not reproduce on this build?
kbecciv commentedon Nov 8, 2023
Checking on special build, will update you shortly
kbecciv commentedon Nov 8, 2023
Issue is not reproducible on special build
Recording.5247.mp4
kbecciv commentedon Nov 8, 2023
@mountiny @situchan Noticed that url changed to /not-found, please verify if QA team need to create a separate issue for this
Recording.5248.mp4