Skip to content

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment #28656

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/

  2. Log in with any Gmail account

  3. Navigate to a chat

  4. Click on the + button in the compose box and upload an attachment
    Online and offline

Expected Result:

Comment appears with grey text "Uploading Attachment" indicating it is pending when navigate to a chat and upload an attachment

Actual Result:

No comment appears with grey text "Uploading Attachment" indicating it is pending when navigate to a chat and upload an attachment. Online and offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • Windows / Chrome
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.76-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6222496_1696280961181.11.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01080e97ce49640c83
  • Upwork Job ID: 1708977224461635584
  • Last Price Increase: 2023-10-02

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2023
  2. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Oct 2, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. mountiny commented on Oct 2, 2023

    @mountiny
    Contributor

    This seems very much related to this blocker #28654

    Would reverting this PR solve it #25557? cc @situchan

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 2, 2023
  8. changed the title [-] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-] [+][$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+] on Oct 2, 2023
  9. 18 remaining items

  10. changed the title [-][$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-] [+][HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+] on Oct 3, 2023
  11. melvin-bot commented on Oct 3, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Oct 3, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-10. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on Oct 3, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. changed the title [-][HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/-] [+][HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment[/+] on Oct 5, 2023
  15. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. kbecciv commented on Nov 8, 2023

    @kbecciv

    Issue not reproduced on build v1.3.96-10

    bandicam.2023-11-08.17-45-01-047.mp4
  18. situchan commented on Nov 8, 2023

    @situchan
    Contributor

    @kbecciv yes, it's expected not reproducible on staging. Did you also not reproduce on this build?

  19. kbecciv commented on Nov 8, 2023

    @kbecciv

    Checking on special build, will update you shortly

  20. kbecciv commented on Nov 8, 2023

    @kbecciv

    Issue is not reproducible on special build

    Recording.5247.mp4
  21. kbecciv commented on Nov 8, 2023

    @kbecciv

    @mountiny @situchan Noticed that url changed to /not-found, please verify if QA team need to create a separate issue for this

    Recording.5248.mp4

    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions