You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Connect Bank account - Crash when completed adding BA manually #28811
changed the title [-]Android - Connect Bank account - Crash when completed adding BA manually[/-][+]Connect Bank account - Crash when completed adding BA manually[/+]on Oct 4, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
App crash for Validate screen in bank account setup flow, It is not crashing for me in ios/android but shows a console warning in the web and it might be the reason for crash.
What is the root cause of that problem?
Seems testId is set to undefined as we don't have value displayName here.
Activity
melvin-bot commentedon Oct 4, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 4, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Android - Connect Bank account - Crash when completed adding BA manually[/-][+]Connect Bank account - Crash when completed adding BA manually[/+]OSBotify commentedon Oct 4, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 4, 2023
Triggered auto assignment to @srikarparsi (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Pujan92 commentedon Oct 4, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crash for Validate screen in bank account setup flow, It is not crashing for me in ios/android but shows a console warning in the web and it might be the reason for crash.
What is the root cause of that problem?
Seems
testIdis set to undefined as we don't have valuedisplayNamehere.App/src/pages/ReimbursementAccount/ValidationStep.js
Line 134 in 24aa7c1
Kind of regression as that page mentioned here but somehow missed in the PR
What changes do you think we should make in order to solve the problem?
Set displayName which won't pass undefined to
testId.ValidationStep.displayName = 'ValidationStep';App/src/pages/ReimbursementAccount/ValidationStep.js
Lines 230 to 232 in 24aa7c1
Note: I skipped the onfido flow step to reach the last step as the crash happened after 4th step. For me it is not crashing
Seems more pages need to be reconsidered as the below list of components is missed within that propsoal.
joekaufmanexpensify commentedon Oct 4, 2023
@srikarparsi will you have a chance to look into this today?
38 remaining items
joekaufmanexpensify commentedon Oct 9, 2023
Not overdue
joekaufmanexpensify commentedon Oct 10, 2023
Applause was able to reproduce as well
melvin-bot commentedon Oct 11, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
joekaufmanexpensify commentedon Oct 13, 2023
Pending proposals
srikarparsi commentedon Oct 16, 2023
Still pending proposals
mvtglobally commentedon Oct 17, 2023
Issue not reproducible during KI retests. (First week)
joekaufmanexpensify commentedon Oct 17, 2023
I'll try to reproduce today again. If I can't I will close!
joekaufmanexpensify commentedon Oct 17, 2023
No longer reproducible for me. Closing!