[HOLD for payment 2023-12-18] Web - Camera border color is different

@gadhiyamanan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to settings > profile
Check the border color around the camera icon

Expected Result:

Border color should be match with background

Actual Result:

Border color is different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.77.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694753216621329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0120fb4ad1be8bb18b
Upwork Job ID: 1709571217501925376
Last Price Increase: 2023-10-25

Job added to Upwork: https://www.upwork.com/jobs/~0120fb4ad1be8bb18b

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

camera border color is different

What is the root cause of that problem?

We are using wrong borderColor

What changes do you think we should make in order to solve the problem?

Change borderColor from textReversed to componentBG and also we can remove the unwanted prop color

App/src/styles/styles.js

Lines 2685 to 2695 in db4d85b

    
           smallEditIcon: { 
        
               alignItems: 'center', 
        
               backgroundColor: theme.buttonHoveredBG, 
        
               borderColor: theme.textReversed, 
        
               borderRadius: 14, 
        
               borderWidth: 3, 
        
               color: theme.textReversed, 
        
               height: 28, 
        
               width: 28, 
        
               justifyContent: 'center', 
        
           },

Proposal

Please re-state the problem that we are trying to solve in this issue.

Border color is different

What is the root cause of that problem?

We are using incorrect borderColor here,

App/src/styles/styles.js

Line 2703 in 96c6c51

borderColor: theme.textReversed,

What changes do you think we should make in order to solve the problem?

Replace theme.textReversed with theme.appBG

smallEditIcon: {
        alignItems: 'center',
        backgroundColor: theme.buttonHoveredBG,
        borderColor: theme.appBG,
        borderRadius: 14,
        borderWidth: 3,
        color: theme.textReversed,
        height: 28,
        width: 28,
        justifyContent: 'center',
    }

What alternative solutions did you explore? (Optional)

NA

Result:

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take a look at this issue.

@grgia

@grgia reporting bonus is pending , can you reopen the issue ...

@sobitneupane

$500 approved for @sobitneupane based on this comment. Also re-opening for BZ to settle the comment above.

@mananjadhav

Offer for @mananjadhav for reporting bonus
@mananjadhav can you please update here when you accept? I am adding a BZ backup as I will be OOO

@MitchExpensify

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@anmurali

@anmurali The offer needs to be sent to @gadhiyamanan.

@gadhiyamanan

The offer is indeed for @gadhiyamanan, thanks for the heads up though @mananjadhav! Please let me know when you have accepted @gadhiyamanan 🙇

@MitchExpensify

@MitchExpensify offer accepted, thanks!

Paid! Thanks

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-18] Web - Camera border color is different #28817

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result:

66 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	smallEditIcon: {
	alignItems: 'center',
	backgroundColor: theme.buttonHoveredBG,
	borderColor: theme.textReversed,
	borderRadius: 14,
	borderWidth: 3,
	color: theme.textReversed,
	height: 28,
	width: 28,
	justifyContent: 'center',
	},

[HOLD for payment 2023-12-18] Web - Camera border color is different #28817

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Oct 4, 2023

melvin-bot commented on Oct 4, 2023

melvin-bot commented on Oct 4, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Oct 4, 2023

gadhiyamanan commented on Oct 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

PiyushChandra17 commented on Oct 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result:

teneeto commented on Oct 5, 2023

66 remaining items

gadhiyamanan commented on Feb 8, 2024

JmillsExpensify commented on Feb 14, 2024

anmurali commented on Feb 16, 2024

melvin-bot commented on Feb 16, 2024

mananjadhav commented on Feb 16, 2024

MitchExpensify commented on Feb 18, 2024

gadhiyamanan commented on Feb 19, 2024

MitchExpensify commented on Feb 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions