Skip to content

[HOLD for payment 2024-04-05] [$500] [MEDIUM] Expensify Cards: Transactions - Update Generic Receipts to use ReceiptBackground #28827

Closed

Description

@grgia

All details needed are below, so no worries if you can't access this!

Overview

Currently for Scan Receipt, we have a few options of png previews for different file types. We need to replace these with the new ReceiptBackground component. Basically, it should be relatively simple, replacing the existing thumbnail with EReceiptThumbnail

We'll also need to update the component to support a label like the existing images - e.g. HTML, PDF, etc.

Design Doc ### Design Doc Section https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=kix.xnc4hi7wlvbg ![Image](https://github.com/Expensify/App/assets/38015950/2ffc776b-4c68-4c3b-94d9-d235207a0ed7)
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d3d6d9c663db1e73
  • Upwork Job ID: 1709590683807113216
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • mollfpr | Contributor | 28092661
    • FitseTLT | Contributor | 28097509

Activity

  1. self-assigned this
    on Oct 4, 2023
  2. added
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 4, 2023
  3. melvin-bot commented on Oct 4, 2023

    @melvin-bot
  4. melvin-bot commented on Oct 4, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

  5. added
    NewFeatureSomething to build that is a new item.
    on Oct 4, 2023
  6. melvin-bot commented on Oct 4, 2023

    @melvin-bot
  7. grgia commented on Oct 13, 2023

    @grgia
    ContributorAuthor

    not overdue, this is just clean up and can be de-prioritized for now

  8. changed the title [-][ECard Transactions] Update Generic Receipts to use ReceiptBackground[/-] [+][ECard Transactions] [Polish] Update Generic Receipts to use ReceiptBackground[/+] on Oct 13, 2023
  9. 95 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 29, 2024
  11. changed the title [-][$500] [MEDIUM] Expensify Cards: Transactions - Update Generic Receipts to use ReceiptBackground[/-] [+][HOLD for payment 2024-04-05] [$500] [MEDIUM] Expensify Cards: Transactions - Update Generic Receipts to use ReceiptBackground[/+] on Mar 29, 2024
  12. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  15. zanyrenney commented on Apr 5, 2024

    @zanyrenney
    Contributor

    payment summary

    @mollfpr requires payment automatic offer (Contributor)
    @FitseTLT requires payment automatic offer (Contributor)- paid $500

  16. mollfpr commented on Apr 5, 2024

    @mollfpr
    Contributor

    [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

    I don't think we need a regression test here.

    @zanyrenney I'll do manual request in NewDot, thank you!

  17. zanyrenney commented on Apr 9, 2024

    @zanyrenney
    Contributor

    payment summary

    @mollfpr requires payment automatic offer (Contributor) to be paid $500 on ND.
    @FitseTLT requires payment automatic offer (Contributor)- paid $500

  18. JmillsExpensify commented on Apr 10, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionECardWave5-free-submittersExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions