Skip to content

[HOLD for payment 2023-10-25] [ECard Transactions] Update MoneyReportView UI #28831

Closed

Description

@grgia

Design Doc Section

https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=kix.814c36x8plt

Overview

Image

Goal:
Update our Money Report Headers to separate out Company and Out-Of-Pocket spend.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3
  • Upwork Job ID: 1709591085181034496
  • Last Price Increase: 2023-10-04

Activity

  1. self-assigned this
    on Oct 4, 2023
  2. added
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 4, 2023
  3. melvin-bot commented on Oct 4, 2023

    @melvin-bot
  4. melvin-bot commented on Oct 4, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

  5. added
    NewFeatureSomething to build that is a new item.
    on Oct 4, 2023
  6. melvin-bot commented on Oct 4, 2023

    @melvin-bot
  7. added
    ReviewingHas a PR in review
    and removed
    ReviewingHas a PR in review
    on Oct 12, 2023
  8. grgia commented on Oct 12, 2023

    @grgia
    ContributorAuthor

    I think this is the last one I need to do for the core UI, will try to get a PR up in the morning to wrap the major FE up

  9. 8 remaining items

  10. melvin-bot commented on Oct 18, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-25. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. melvin-bot commented on Oct 18, 2023

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  12. s77rt commented on Oct 19, 2023

    @s77rt
    Member

    @grgia Do we need a regression test here? I'm not sure what would be the test steps from the user/qa perspective to reproduce this

  13. lschurr commented on Oct 25, 2023

    @lschurr
    Contributor

    Payment summary:

    Contributor+: @s77rt $500

  14. lschurr commented on Oct 25, 2023

    @lschurr
    Contributor

    @s77rt remind me - are you paid via Newdot or Upwork?

  15. s77rt commented on Oct 25, 2023

    @s77rt
    Member

    @lschurr Upwork

  16. lschurr commented on Oct 25, 2023

    @lschurr
    Contributor

    Great! Are you able to apply here @s77rt? https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3

  17. s77rt commented on Oct 25, 2023

    @s77rt
    Member

    @lschurr Applied! Thanks!

  18. lschurr commented on Oct 25, 2023

    @lschurr
    Contributor

    Offer sent @s77rt!

  19. s77rt commented on Oct 25, 2023

    @s77rt
    Member

    Accepted!

  20. lschurr commented on Oct 25, 2023

    @lschurr
    Contributor

    Great! Paid. Closing.

  21. melvin-bot commented on Oct 30, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions