You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-01] [$500] [Form Provider Refactor] CloseAccountPage #28870
changed the title [-][$500] [Form Provider Refactor] CloseAccountPage[/-][+][HOLD for payment 2023-11-01] [$500] [Form Provider Refactor] CloseAccountPage[/+]on Oct 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-01. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
[@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@narefyev91] Determine if we should create a regression test for this bug.
[@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 4, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01e0b63c230cc9d136
melvin-bot commentedon Oct 4, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (
Internal)[-]Refactor CloseAccountPage to use new FormProvider[/-][+][Form Provider Refactor] CloseAccountPage[/+]melvin-bot commentedon Oct 4, 2023
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 4, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kowczarz commentedon Oct 5, 2023
Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.
27 remaining items
[-][$500] [Form Provider Refactor] CloseAccountPage[/-][+][HOLD for payment 2023-11-01] [$500] [Form Provider Refactor] CloseAccountPage[/+]melvin-bot commentedon Oct 25, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-01. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 25, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Oct 31, 2023
No payments required.
This is a refactor - also no checklist needed.