[HOLD for payment 2023-12-06] [HOLD for payment 2023-11-09] [$500] [Form Provider Refactor] AddDebitCardPage

@kowczarz

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/settings/Wallet/AddDebitCardPage.js

cc @kowczarz

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b882bb5f74f3ae3b
Upwork Job ID: 1709705671346003968
Last Price Increase: 2023-10-05

Job added to Upwork: https://www.upwork.com/jobs/~01b882bb5f74f3ae3b

@dylanexpensify

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@parasharrajat

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Form Provider Refactor] AddDebitCardPage fixes #31133

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@parasharrajat does not require payment (Eligible for Manual Requests)
@kowczarz does not require payment (Contractor)

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

payment upcoming!

@kowczarz

Payment summary:

Contributor: @kowczarz (SWM)
Contributor+: @parasharrajat $500

Please apply!

@dylanexpensify

@dylanexpensify you can close this issue. I will request later. Thanks.

Payment requested as per #28876 (comment)

@parasharrajat

$500 approved for @parasharrajat

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-06] [HOLD for payment 2023-11-09] [$500] [Form Provider Refactor] AddDebitCardPage #28876

Bug0 Triage Checklist (Main S/O)

51 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-12-06] [HOLD for payment 2023-11-09] [$500] [Form Provider Refactor] AddDebitCardPage #28876

Description

Activity

melvin-bot commented on Oct 4, 2023

melvin-bot commented on Oct 4, 2023

melvin-bot commented on Oct 4, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Oct 4, 2023

kowczarz commented on Oct 5, 2023

51 remaining items

melvin-bot commented on Nov 29, 2023

melvin-bot commented on Nov 29, 2023

dylanexpensify commented on Dec 5, 2023

dylanexpensify commented on Dec 11, 2023

parasharrajat commented on Dec 11, 2023

parasharrajat commented on Apr 5, 2024

JmillsExpensify commented on Apr 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions