You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open #28926
Start typing anything and observe that app writes everything in composer even though RHN is open
Expected Result:
App should not focus back on composer if RHN is open
Actual Result:
App focuses back on composer even if RHN is open on copy link from app download link in about settings
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native - not testable
Android / Chrome - not testable
iOS / native - not testable
iOS / Safari - not testable
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.78.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Chat - App refocuses on composer even when RHN is open[/-][+][$500] Chat - App refocuses on composer even when RHN is open[/+]on Oct 5, 2023
Please re-state the problem that we are trying to solve in this issue.
App focuses back on composer even if RHN is open on copy link from app download link in about settings
What is the root cause of that problem?
In here, after copying the link, we're always refocusing on the composer, even in the case where another route is open.
What changes do you think we should make in order to solve the problem?
In there, we should check that the active route is the report route, if yes we trigger the refocusing. For example, we can do something like this
if (!Navigation.isActiveRoute(ROUTES.REPORT_WITH_ID.getRoute(Navigation.getTopmostReportId()))) {
return;
}
(This can be checked here or inside ReportActionComposeFocusManager.focus, where it will take effect for all attempts to focus the composers)
What alternative solutions did you explore? (Optional)
This might happen for other opened context menu as well, we should double check and fix the same for those places.
If we decide to add the check in ReportActionComposeFocusManager.focus then it will work for all places.
📣 @chahedmoetaz! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor+: @mananjadhav $750 (inc urgency bonus) - @mananjadhav please complete the above checklist, notify me here, and then request payment via NewDot.
I think this change exists since a long time. I couldn't pinpoint it to a specific PR.
Neither do I think we need a regression test for this one. We've anyway fixed this at the Composer level, so less likely to occur again. cc - @peterdbarkerUK
changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Chat - App refocuses on composer even when RHN is open[/-][+][HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open[/+]on Oct 27, 2023
Activity
[-]Chat - App refocuses on composer even when RHN is open[/-][+][$500] Chat - App refocuses on composer even when RHN is open[/+]melvin-bot commentedon Oct 5, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a7a9e4d7988e32e2
melvin-bot commentedon Oct 5, 2023
Triggered auto assignment to @peterdbarkerUK (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 5, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)martin12345678900 commentedon Oct 5, 2023
Can't reproduce :/
dukenv0307 commentedon Oct 5, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App focuses back on composer even if RHN is open on copy link from app download link in about settings
What is the root cause of that problem?
In here, after copying the link, we're always refocusing on the composer, even in the case where another route is open.
What changes do you think we should make in order to solve the problem?
In there, we should check that the active route is the report route, if yes we trigger the refocusing. For example, we can do something like this
(This can be checked here or inside
ReportActionComposeFocusManager.focus, where it will take effect for all attempts to focus the composers)What alternative solutions did you explore? (Optional)
This might happen for other opened context menu as well, we should double check and fix the same for those places.
If we decide to add the check in
ReportActionComposeFocusManager.focusthen it will work for all places.chahedmoetaz commentedon Oct 5, 2023
Any updates?
melvin-bot commentedon Oct 5, 2023
📣 @chahedmoetaz! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
34 remaining items
peterdbarkerUK commentedon Oct 24, 2023
Summarizing payouts for this issue:
Issue reporter: @dhanashree-sawant $50
Contributor: @dukenv0307 $750 (inc urgency bonus)
Contributor+: @mananjadhav $750 (inc urgency bonus) - @mananjadhav please complete the above checklist, notify me here, and then request payment via NewDot.
Upwork Job
mananjadhav commentedon Oct 24, 2023
I think this change exists since a long time. I couldn't pinpoint it to a specific PR.
Neither do I think we need a regression test for this one. We've anyway fixed this at the Composer level, so less likely to occur again. cc - @peterdbarkerUK
JmillsExpensify commentedon Oct 24, 2023
$750 payment approved for @mananjadhav based on summary above.
[-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Chat - App refocuses on composer even when RHN is open[/-][+][HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open[/+]luacmartins commentedon Oct 27, 2023
Just pending payment.
mananjadhav commentedon Oct 27, 2023
@peterdbarkerUK Is the payout done for @dukenv0307 @dhanashree-sawant ? If yes then we're good to close here.
luacmartins commentedon Oct 30, 2023
Just pending confirmation for the above
peterdbarkerUK commentedon Oct 30, 2023
Yep, they were both paid last week! Job removed and closing :)
I'm sorry for the slow followup while I was OoO last week.