Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.79-5
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Gyroscope-driven animations of empty chats #23737
- [NoQA] Check for boolean input values #23910
- [No QA] [TS migration] Migrate 'focusAndUpdateMultilineInputRange.js' lib to TypeScript #26234
- Add DraggableList component #26307
- Added option to get user's current location #26546
- Add “Reveal details” for the digital card #26778
- Fixed no result found after selecting a address from the drop-down menu #27035
- fix: 26657 Another error message for a short time when opening archived chat from search bar #27420
- Fix auto scroll when the display name is changed #27632
- Apply Onyx failureData on fetch failure #27650
- [No QA] [TS migration] Migrate 'ActiveClientManager' lib to TypeScript #27792
- Converted SidebarLinks to fn component and improve use of window props #27855
- [No QA] [TS migration] Migrate 'PusherUtils.js' lib to TypeScript #27918
- [TS migration] Migrate 'PaymentUtils.js' lib to TypeScript #27923
- Fix: Approved requests shouldn't have a delete option #27952
- fix: get styles based on state numberOfLines #28188
- fix: mark propTypes policy as optional and provides default value #28213
- fix: use the same sort order for header display names and avatars in a group chat view #28218
- fix: send message - user navigates to Room tab when dragging to select e-mail from Chat tab #28240
- fix message in LHN when scanning #28244
- [ECard Transactions] Update
TransactionsandReportTS Types #28246 - [No QA] [TS migration] Migrate 'IntlPolyfill' lib to TypeScript #28306
- Fix/26392: Changing Currency in IOU Causes Account Email to Replace Request Email #28350
- [NoQA] Add max retry request #28365
- Fix pronouns is empty when we access by deep link after signing in #28368
- Hide replace option for the request that cannot edit #28373
- Update Lyft.md #28376
- Add pending fields when edit task assignee #28378
- Create Add-a-Business-Bank-Account-(AUD).md #28385
- Fix scroll behind suggestion list when scrolling on suggestion popup #28389
- Create connect-ANZ.md #28394
- Submit recovery code when enter is pressed #28409
- Add Help site images via upload #28425
- Remove optimistic personal detail after requesting money #28426
- [NoQA] Update Lyft.md #28429
- [NoQA] Update Trip-Actions.md #28445
- Replace popup closes after image on ESC #28451
- Fix input lost focus when entering on no result found #28459
- Update Per-Diem.md #28513
- Issue 28059 fix emoji reactions in offline mode #28519
- Update migration for report.participants and report.lastActorEmail #28555
- Create Other-Export-Options.md #28575
- Fix LHN popover showing in Report screen #28614
- Strikethrough link is not parsed correctly on link with URL that contains tilde #28616
- [No QA] Turn off multiple withOnyx eslint rule for now #28624
- [NoQA] From docs refactor #28627
- Fix: Hover effect lost after opening popover again before closing it #28639
- fix: room name field does not automatically focus when returning from the chat option #28646
- fix: keep trailing spaces in heading #28674
- remove validate when blur #28675
- Update FinancalForce.md #28676
- Revert "fix: Refocus issue on address field on delete and cancel" #28677
- Disable flash when there is no permission granted #28680
- Fix/27779: Expand button disappear after clicking send #28681
- fix: 28354 Report screen becomes empty when resizing to big size from LHN #28683
- Fix: emoji picker hides on resize window #28688
- remove: unnecessary flex to correctly display the inline code #28700
- Fix LHN is disappeared when leaving thread #28702
- fix: Android - User can't open context menu by long press on code block. #28709
- feat: migrate onfido native class component to functional #28714
- fix: show scrollbar if applicable #28720
- [No QA] Upgrade react-native-onyx to 1.0.98 #28725
- Fix precision error when creating distance request #28734
- [NoQA] Include link to slack thread about the mapbox token #28735
- fix: 28548 #28736
- removed extra line below description when we use enter to save the description #28739
- Fix popover position for payment buttons #28744
- Update Consolidated-Domain-Billing.md #28745
- Adding Expensify Card dispute help site article #28755
- fix: clear the input when resending validate code #28757
- fix: "user is typing" event sent when force offline mode is enabled #28786
- Fix:
GetReportPrivateNotegets called continuously #28787 - Add images for HelpDot Reimbursing Reports #28788
- Correctly display merchant error #28791
- [CP Staging] Revert "Handle suggestions only on selection change" #28794
- [CP Staging] Fix: No notification when closing account #28800
- Fix regression task preview #28809
- Initial fix #28812
- feat: migrate onfido web component from class to functioncal #28815
- [NoQA] Increase number of e2e test runs #28822
- Fix private notes raw text links issue #28843
- Fix: City field is lost when login again by deeplink #28845
- [CP Staging] fix: Distance - App crashes when tapping on the receipt thumbnail while receipt is generating #28852
- [CP Staging] fix persisted request #28857
- fix: room avatars attachment modal shouldn't close when avatar image is updated #28868
- [NoQA] Access the paymentType of report action safely #28881
- Setup Cloudflare Pages for Docs Preview #28886
- Remove part that says Expensify doesn't use Prettier in README #28891
- Fix show waypoint address suggestions of all types #28938
- [CP Staging] Revert "fix: 26657 Another error message for a short time when opening archived chat from search bar" #29106
- Revert "Initial fix" #29126
Deploy Blockers:
- [HOLD for payment 2023-12-15] [$500]Thread - Undefined displayed in header offline when opening left thread #28997
- Android - Distance - Error shows up when location access is limited to approximate location #29008
- [$500] Distance - Clicking on Use current location when suggestion list is open does not trigger action #29015
- [HOLD for payment 2023-11-09] [$500] BA - Part of the screen shakes when entering an address offline #29030
- Workspace - Different skeleton is displayed at the bottom of the archived workspace room #29032
- [HOLD for payment 2023-10-18] [HOLD for payment 2023-10-16] Chat - Loading appears instead of archived message #29087
- [$500] Hmm.. it's not here page is displayed when opening a 'share code' link for public account only #29088
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
Beamanator commentedon Oct 6, 2023
Checked these off b/c they were on the old checklist:
GetReportPrivateNotegets called continuously #28787OSBotify commentedon Oct 6, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.79-2 🚀
kavimuru commentedon Oct 6, 2023
Checked off the PRs from the past builds
#26778
#28794
#28800
#28852
#28857
#28745,#28755 checked off (help.expensify.com)
luacmartins commentedon Oct 6, 2023
Checking off #29008. Demoted to NAB since it comes from external libs
kavimuru commentedon Oct 6, 2023
Regression TR is at 66% progress. We are validating few PRs in iOS platform.
#27420 failing with #29032
kavimuru commentedon Oct 8, 2023
Regression TR is at 98% . We still see desktop app version 79-2. Are we okay to proceed?
#27420 failing with #29032
#28744 failing with #29016 (But this is not a bug as per this comment #28744 (comment)) - checking off
#26546 is failing with #29008 in android
#27952 is failing with #29010 reproducible in production- checking it off
#28845 is failing with #29060 reproducible in production (ok to check it off?)
kavimuru commentedon Oct 8, 2023
TR regression is 1% left to be completed.
#27420 failing with #29032
#26546 is failing with #29008 in android
#28845 is failing with #29060 reproducible in production (ok to check it off?)
#28683 is failing with #28354 (not fixed in web and desktop)
#28646 is failing with #29001 reproducible in production - checking it off
mvtglobally commentedon Oct 9, 2023
Regression is completed
Open blockers:
#29030
#29032
Unchecked PRs:
#27420 failing with #29032
#26546 is failing with #29008 in android
#28683 is failing with #28354 (not fixed in web and desktop)
#28845 is failing with #29060 reproducible in production. Main PR is marked as a blocker. are we ok to check it off?
amyevans commentedon Oct 9, 2023
Checked off #29087 after CPing a revert
jasperhuangg commentedon Oct 9, 2023
Checking it off 👍
jasperhuangg commentedon Oct 9, 2023
Checking off this revert: #29106
jasperhuangg commentedon Oct 9, 2023
I'm going to check off #28683 since the issue it fixes is reproducible on production, and it partially fixes that issue. I've notified the contributor to look into it again.
jasperhuangg commentedon Oct 9, 2023
CP'd a fix for #29088
jasperhuangg commentedon Oct 9, 2023
Checking off #26546. It doesn't appear to be a bug on our side that's blocking it.
jasperhuangg commentedon Oct 9, 2023
Checking off #27420 per #29032 (comment)
jasperhuangg commentedon Oct 9, 2023
OSBotify commentedon Oct 9, 2023
This issue either has unchecked items or has not yet been marked with the
:shipit:emoji of approval.Reopening!
jasperhuangg commentedon Oct 9, 2023