You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-27] [$500] Double tap on emoji selects am/pm of the time of the message #29021
Send any emoji or emoji plus text (ensure emoji is first)
Double click on left half of emoji and observe that it select emoji plus AM/PM of above time
Expected Result:
App should not select AM/PM from time above on double click selection of emoji
Actual Result:
App selects AM/PM from time above on double click selection of emoji
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.79.-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Double tap on emoji selects am/pm of the time of the message[/-][+][$500] Double tap on emoji selects am/pm of the time of the message[/+]on Oct 6, 2023
Please re-state the problem that we are trying to solve in this issue.
Double tap on emoji selects am/pm of the time of the message
What is the root cause of that problem?
The problem occurs because in the rendering, am/pm and the emoji become the same word and when double-clicking both are selected as if they were one.
What changes do you think we should make in order to solve the problem?
We must separate the words by adding a Non-breaking space at the end of the date (am/pm in the rendering) and add a style of userSelect: none so that the selection is clean.
Please re-state the problem that we are trying to solve in this issue.
Double tap on emoji selects am/pm of the time of the message
What is the root cause of that problem?
The problem is related to the way Chrome handles text selection in some cases. It can happen when there are overlapping elements or unusual styling applied to the content.
What changes do you think we should make in order to solve the problem?
We must add a simple css style to am/pm div
What alternative solutions did you explore? (Optional)
NA
📣 @KunwarSingh! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Please re-state the problem that we are trying to solve in this issue.
Double tap on emoji selects am/pm of the time of the message
What is the root cause of that problem?
The problem is related to the way Chrome handles text selection in some cases. It can happen when there are overlapping elements or unusual styling applied to the content.
What changes do you think we should make in order to solve the problem?
We must add a simple css style to am/pm div
What alternative solutions did you explore? (Optional)
NA
Activity
[-]Double tap on emoji selects am/pm of the time of the message[/-][+][$500] Double tap on emoji selects am/pm of the time of the message[/+]melvin-bot commentedon Oct 6, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0149fb66dc1d8f480d
melvin-bot commentedon Oct 6, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (
External)GianlucaMina commentedon Oct 6, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Double tap on emoji selects am/pm of the time of the message
What is the root cause of that problem?
The problem occurs because in the rendering, am/pm and the emoji become the same word and when double-clicking both are selected as if they were one.
What changes do you think we should make in order to solve the problem?
We must separate the words by adding a Non-breaking space at the end of the date (am/pm in the rendering) and add a style of userSelect: none so that the selection is clean.
The modification would occur on this line
App/src/pages/home/report/ReportActionItemDate.js
Line 16 in 6682740
It would be something like this
What alternative solutions did you explore? (Optional)
Alternatively the style can be moved to styles.js or another file of convenience
Final Result
4052c31f-61a2-415d-80ea-404717bbb1c5.webm
1adebe6f-45d1-4d96-aeec-3a7504007c39.mp4
KunwarSingh commentedon Oct 6, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Double tap on emoji selects am/pm of the time of the message
What is the root cause of that problem?
The problem is related to the way Chrome handles text selection in some cases. It can happen when there are overlapping elements or unusual styling applied to the content.
What changes do you think we should make in order to solve the problem?
We must add a simple css style to am/pm div
What alternative solutions did you explore? (Optional)
NA
Contributor details
Your Expensify account email: thekunwarsingh@gmail.com
Upword Profile Link: https://www.upwork.com/freelancers/~0174c13534125c9866
melvin-bot commentedon Oct 6, 2023
📣 @KunwarSingh! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
KunwarSingh commentedon Oct 6, 2023
Contributor details
Your Expensify account email: thekunwarsingh@gmail.com
Upword Profile Link: https://www.upwork.com/freelancers/~0174c13534125c9866
KunwarSingh commentedon Oct 6, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Double tap on emoji selects am/pm of the time of the message
What is the root cause of that problem?
The problem is related to the way Chrome handles text selection in some cases. It can happen when there are overlapping elements or unusual styling applied to the content.
What changes do you think we should make in order to solve the problem?
We must add a simple css style to am/pm div
What alternative solutions did you explore? (Optional)
NA
Contributor details
Your Expensify account email: thekunwarsingh@gmail.com
Upword Profile Link: https://www.upwork.com/freelancers/~0174c13534125c9866
KunwarSingh commentedon Oct 6, 2023
@narefyev91 I can quickly resolve this and push a fix to web and desktop app
fixed.mov
ayazalavi commentedon Oct 6, 2023
@KunwarSingh what is the css you are adding? Can you still select PM after adding css?
KunwarSingh commentedon Oct 6, 2023
separately PM can be selected, but if we double click its not
74 remaining items
melvin-bot commentedon Nov 13, 2023
@ayazalavi, @Li357, @anmurali, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Nov 13, 2023
@ayazalavi, @Li357, @anmurali, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Li357 commentedon Nov 13, 2023
Any updates here?
melvin-bot commentedon Nov 20, 2023
@ayazalavi, @Li357, @anmurali, @narefyev91 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
melvin-bot commentedon Nov 22, 2023
@ayazalavi, @Li357, @anmurali, @narefyev91 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Nov 24, 2023
@ayazalavi, @Li357, @anmurali, @narefyev91 12 days overdue now... This issue's end is nigh!
melvin-bot commentedon Nov 27, 2023
This issue has not been updated in over 14 days. @ayazalavi, @Li357, @anmurali, @narefyev91 eroding to Weekly issue.
anmurali commentedon Dec 6, 2023
@ayazalavi has been paid back on Nov 10. @narefyev91 is a call stack engineer and is handled via invoice. @dhanashree-sawant has also been paid. Closing!
ayazalavi commentedon Jan 21, 2024
@anmurali can you give me ratings in upwork please.
@narefyev91