Skip to content

[HOLD for payment 2023-10-27] [$500] Double tap on emoji selects am/pm of the time of the message #29021

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Send any emoji or emoji plus text (ensure emoji is first)
  4. Double click on left half of emoji and observe that it select emoji plus AM/PM of above time

Expected Result:

App should not select AM/PM from time above on double click selection of emoji

Actual Result:

App selects AM/PM from time above on double click selection of emoji

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.79.-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

mac.chrome.desktop.double.click.copy.AM.PM.mov
windows.chrome.double.tap.selects.AM.PM.mp4
Recording.10.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696582198838549

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0149fb66dc1d8f480d
  • Upwork Job ID: 1710346408992141312
  • Last Price Increase: 2023-10-06
  • Automatic offers:
    • dhanashree-sawant | Reporter | 27220198
Issue OwnerCurrent Issue Owner: @anmurali

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 6, 2023
  2. changed the title [-]Double tap on emoji selects am/pm of the time of the message[/-] [+][$500] Double tap on emoji selects am/pm of the time of the message[/+] on Oct 6, 2023
  3. melvin-bot commented on Oct 6, 2023

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 6, 2023
  5. melvin-bot commented on Oct 6, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

  6. GianlucaMina commented on Oct 6, 2023

    @GianlucaMina

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Double tap on emoji selects am/pm of the time of the message

    What is the root cause of that problem?

    The problem occurs because in the rendering, am/pm and the emoji become the same word and when double-clicking both are selected as if they were one.

    What changes do you think we should make in order to solve the problem?

    We must separate the words by adding a Non-breaking space at the end of the date (am/pm in the rendering) and add a style of userSelect: none so that the selection is clean.

    <span style={{userSelect: "none"}}>&nbsp;</span>
    

    The modification would occur on this line

    return <Text style={[styles.chatItemMessageHeaderTimestamp]}>{props.datetimeToCalendarTime(props.created)}</Text>;

    It would be something like this

    return <Text style={[styles.chatItemMessageHeaderTimestamp]}>{props.datetimeToCalendarTime(props.created)}<span style={{userSelect: "none"}}>&nbsp;</span></Text>;
    

    What alternative solutions did you explore? (Optional)

    Alternatively the style can be moved to styles.js or another file of convenience

    Final Result

    4052c31f-61a2-415d-80ea-404717bbb1c5.webm
    1adebe6f-45d1-4d96-aeec-3a7504007c39.mp4
  7. KunwarSingh commented on Oct 6, 2023

    @KunwarSingh

    Proposal

    Please re-state the problem that we are trying to solve in this issue.
    Double tap on emoji selects am/pm of the time of the message

    What is the root cause of that problem?

    The problem is related to the way Chrome handles text selection in some cases. It can happen when there are overlapping elements or unusual styling applied to the content.

    What changes do you think we should make in order to solve the problem?

    We must add a simple css style to am/pm div

    What alternative solutions did you explore? (Optional)
    NA

    Contributor details

    Your Expensify account email: thekunwarsingh@gmail.com
    Upword Profile Link: https://www.upwork.com/freelancers/~0174c13534125c9866

  8. melvin-bot commented on Oct 6, 2023

    @melvin-bot

    📣 @KunwarSingh! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  9. KunwarSingh commented on Oct 6, 2023

    @KunwarSingh

    Contributor details

    Your Expensify account email: thekunwarsingh@gmail.com
    Upword Profile Link: https://www.upwork.com/freelancers/~0174c13534125c9866

  10. KunwarSingh commented on Oct 6, 2023

    @KunwarSingh

    Proposal

    Please re-state the problem that we are trying to solve in this issue.
    Double tap on emoji selects am/pm of the time of the message

    What is the root cause of that problem?

    The problem is related to the way Chrome handles text selection in some cases. It can happen when there are overlapping elements or unusual styling applied to the content.

    What changes do you think we should make in order to solve the problem?

    We must add a simple css style to am/pm div

    What alternative solutions did you explore? (Optional)
    NA

    Contributor details

    Your Expensify account email: thekunwarsingh@gmail.com
    Upword Profile Link: https://www.upwork.com/freelancers/~0174c13534125c9866

  11. KunwarSingh commented on Oct 6, 2023

    @KunwarSingh

    @narefyev91 I can quickly resolve this and push a fix to web and desktop app

    fixed.mov
  12. ayazalavi commented on Oct 6, 2023

    @ayazalavi
    Contributor

    @KunwarSingh what is the css you are adding? Can you still select PM after adding css?

  13. KunwarSingh commented on Oct 6, 2023

    @KunwarSingh

    separately PM can be selected, but if we double click its not

  14. 74 remaining items

  15. melvin-bot commented on Nov 13, 2023

    @melvin-bot

    @ayazalavi, @Li357, @anmurali, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. melvin-bot commented on Nov 13, 2023

    @melvin-bot

    @ayazalavi, @Li357, @anmurali, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. Li357 commented on Nov 13, 2023

    @Li357
    Contributor

    Any updates here?

  18. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    @ayazalavi, @Li357, @anmurali, @narefyev91 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  19. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    @ayazalavi, @Li357, @anmurali, @narefyev91 10 days overdue. Is anyone even seeing these? Hello?

  20. melvin-bot commented on Nov 24, 2023

    @melvin-bot

    @ayazalavi, @Li357, @anmurali, @narefyev91 12 days overdue now... This issue's end is nigh!

  21. melvin-bot commented on Nov 27, 2023

    @melvin-bot

    This issue has not been updated in over 14 days. @ayazalavi, @Li357, @anmurali, @narefyev91 eroding to Weekly issue.

  22. anmurali commented on Dec 6, 2023

    @anmurali

    @ayazalavi has been paid back on Nov 10. @narefyev91 is a call stack engineer and is handled via invoice. @dhanashree-sawant has also been paid. Closing!

  23. ayazalavi commented on Jan 21, 2024

    @ayazalavi
    Contributor

    @anmurali can you give me ratings in upwork please.
    @narefyev91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions