You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-27] [$250] Dev: Emojipicker in Set status page has a text cursor instead of pointer #29097
Emojipicker in Set status page has a "text" cursor instead of pointer
Root Cause
We are setting the accessibilityRole="text" for PressableWithoutFeedback used for the dropdown which result in curesor style as "text" I have aasked clarifying question why we used "text" instead of "button" (here)[https://github.com//pull/23267]
Changes
We can change accessibilityRole=CONST.ACCESSIBILITY_ROLE.BUTTON or expilicty add cursor style to cursorPointer and cursorDisabled when disabled
Emojipicker in Set status page has a "text" cursor instead of pointer
Root Cause
We are setting the accessibilityRole="text" for PressableWithoutFeedback used for the dropdown which result in cursor style as "text". I have asked clarifying question why we used "text" instead of "button" here
Changes
We can change accessibilityRole=CONST.ACCESSIBILITY_ROLE.BUTTON or expilicty add cursor style to cursorPointer and cursorDisabled when disabled
changed the title [-]Dev: Emojipicker in Set status page has a "text" cursor instead of pointer[/-][+]Dev: Emojipicker in Set status page has a text cursor instead of pointer[/+]on Oct 9, 2023
changed the title [-]Dev: Emojipicker in Set status page has a text cursor instead of pointer[/-][+][$500] Dev: Emojipicker in Set status page has a text cursor instead of pointer[/+]on Oct 9, 2023
I think this is really minor and a regression test is not needed. However, if there's disagreement, then the steps given in the OP seems to be clear enough.
Activity
melvin-bot commentedon Oct 9, 2023
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam
saranshbalyan-1234 commentedon Oct 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Emojipicker in Set status page has a "text" cursor instead of pointer
What is the root cause of that problem?
We have not added styles for pointer cursor here.
App/src/styles/styles.js
Lines 3539 to 3550 in 389d7b0
What changes do you think we should make in order to solve the problem?
add ...cursor.cursorPointer at the end of emojiPickerButtonDropdown
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Oct 9, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)kbecciv commentedon Oct 9, 2023
Proposal by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696763872801869
Proposal
Problem
Emojipicker in Set status page has a "text" cursor instead of pointer
Root Cause
We are setting the accessibilityRole="text" for PressableWithoutFeedback used for the dropdown which result in curesor style as "text" I have aasked clarifying question why we used "text" instead of "button" (here)[https://github.com//pull/23267]
Changes
We can change accessibilityRole=CONST.ACCESSIBILITY_ROLE.BUTTON or expilicty add cursor style to cursorPointer and cursorDisabled when disabled
Reply…
Also send to expensify-bugs
ishpaul777 commentedon Oct 9, 2023
edit : Fixed some typos from ^
Proposal
Problem
Emojipicker in Set status page has a "text" cursor instead of pointer
Root Cause
We are setting the accessibilityRole="text" for PressableWithoutFeedback used for the dropdown which result in cursor style as "text". I have asked clarifying question why we used "text" instead of "button" here
Changes
We can change
accessibilityRole=CONST.ACCESSIBILITY_ROLE.BUTTONor expilicty add cursor style to cursorPointer and cursorDisabled when disabled[-]Dev: Emojipicker in Set status page has a "text" cursor instead of pointer[/-][+]Dev: Emojipicker in Set status page has a text cursor instead of pointer[/+][-]Dev: Emojipicker in Set status page has a text cursor instead of pointer[/-][+][$500] Dev: Emojipicker in Set status page has a text cursor instead of pointer[/+]melvin-bot commentedon Oct 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~018aae903757e06f35
49 remaining items
melvin-bot commentedon Nov 13, 2023
@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Nov 13, 2023
@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Nov 13, 2023
@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...
JmillsExpensify commentedon Nov 15, 2023
@allroundexperts Looks like this one lacks a checklist, though at that point I can approve payment and we can close this one out.
melvin-bot commentedon Nov 21, 2023
@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Nov 23, 2023
@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
JmillsExpensify commentedon Nov 24, 2023
Still awaiting a checklist.
JmillsExpensify commentedon Nov 24, 2023
Actually, going to go ahead and close this one out. I can verify checklist ahead of approving payment via NewDot.
allroundexperts commentedon Nov 28, 2023
Checklist
JmillsExpensify commentedon Nov 28, 2023
Thanks @allroundexperts. $375 payment approved based on this comment.