Skip to content

[HOLD for payment 2023-10-27] [$250] Dev: Emojipicker in Set status page has a text cursor instead of pointer #29097

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Dev 1.3.79.3
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696763872801869

Action Performed:

Pre condition: Make sure you have Beta for status feature

  1. Navigate to Profile -> Status -> Set Status
  2. Hover on Emoji Picker Drop Down Button

Expected Result:

Emojipicker Dropdown button has a pointer cursor

Actual Result:

Emojipicker Dropdown button has a text cursor.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
n/a
Android: mWeb Chrome
n/a
iOS: Native
n/a
iOS: mWeb Safari
n/a
MacOS: Chrome / Safari
Screen.Recording.2023-10-08.at.4.42.59.PM.mov
MacOS: Desktop
Screen.Recording.2023-10-08.at.4.51.16.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018aae903757e06f35
  • Upwork Job ID: 1711460039105232896
  • Last Price Increase: 2023-10-10
  • Automatic offers:
    • ishpaul777 | Contributor | 27225708
    • ishpaul777 | Reporter | 27225711
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 9, 2023
  2. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 9, 2023
  4. saranshbalyan-1234 commented on Oct 9, 2023

    @saranshbalyan-1234
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Emojipicker in Set status page has a "text" cursor instead of pointer

    What is the root cause of that problem?

    We have not added styles for pointer cursor here.

    App/src/styles/styles.js

    Lines 3539 to 3550 in 389d7b0

    emojiPickerButtonDropdown: {
    justifyContent: 'center',
    backgroundColor: theme.activeComponentBG,
    width: 86,
    height: 52,
    borderRadius: 26,
    alignItems: 'center',
    paddingLeft: 10,
    paddingRight: 4,
    marginBottom: 32,
    alignSelf: 'flex-start',
    },

    What changes do you think we should make in order to solve the problem?

    add ...cursor.cursorPointer at the end of emojiPickerButtonDropdown

      emojiPickerButtonDropdown: {
            justifyContent: 'center',
            backgroundColor: theme.activeComponentBG,
            width: 86,
            height: 52,
            borderRadius: 26,
            alignItems: 'center',
            paddingLeft: 10,
            paddingRight: 4,
            marginBottom: 32,
            alignSelf: 'flex-start',
            ...cursor.cursorPointer,
    
        },

    What alternative solutions did you explore? (Optional)

    N/A

  5. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  6. kbecciv commented on Oct 9, 2023

    @kbecciv
    Author

    Proposal by: @ishpaul777
    Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696763872801869

    Proposal

    Problem

    Emojipicker in Set status page has a "text" cursor instead of pointer

    Root Cause

    We are setting the accessibilityRole="text" for PressableWithoutFeedback used for the dropdown which result in curesor style as "text" I have aasked clarifying question why we used "text" instead of "button" (here)[https://github.com//pull/23267]

    Changes

    We can change accessibilityRole=CONST.ACCESSIBILITY_ROLE.BUTTON or expilicty add cursor style to cursorPointer and cursorDisabled when disabled

    Reply…
    Also send to expensify-bugs

  7. ishpaul777 commented on Oct 9, 2023

    @ishpaul777
    Contributor

    edit : Fixed some typos from ^

    Proposal

    Problem

    Emojipicker in Set status page has a "text" cursor instead of pointer

    Root Cause

    We are setting the accessibilityRole="text" for PressableWithoutFeedback used for the dropdown which result in cursor style as "text". I have asked clarifying question why we used "text" instead of "button" here

    Changes

    We can change accessibilityRole=CONST.ACCESSIBILITY_ROLE.BUTTON or expilicty add cursor style to cursorPointer and cursorDisabled when disabled

  8. changed the title [-]Dev: Emojipicker in Set status page has a "text" cursor instead of pointer[/-] [+]Dev: Emojipicker in Set status page has a text cursor instead of pointer[/+] on Oct 9, 2023
  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 9, 2023
  10. changed the title [-]Dev: Emojipicker in Set status page has a text cursor instead of pointer[/-] [+][$500] Dev: Emojipicker in Set status page has a text cursor instead of pointer[/+] on Oct 9, 2023
  11. melvin-bot commented on Oct 9, 2023

    @melvin-bot
  12. 49 remaining items

  13. melvin-bot commented on Nov 13, 2023

    @melvin-bot

    @JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

  14. melvin-bot commented on Nov 13, 2023

    @melvin-bot

    @JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

  15. melvin-bot commented on Nov 13, 2023

    @melvin-bot

    @JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

  16. JmillsExpensify commented on Nov 15, 2023

    @JmillsExpensify
    Contributor

    @allroundexperts Looks like this one lacks a checklist, though at that point I can approve payment and we can close this one out.

  17. melvin-bot commented on Nov 21, 2023

    @melvin-bot

    @JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

  18. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    @JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  19. JmillsExpensify commented on Nov 24, 2023

    @JmillsExpensify
    Contributor

    Still awaiting a checklist.

  20. JmillsExpensify commented on Nov 24, 2023

    @JmillsExpensify
    Contributor

    Actually, going to go ahead and close this one out. I can verify checklist ahead of approving payment via NewDot.

  21. allroundexperts commented on Nov 28, 2023

    @allroundexperts
    Contributor

    Checklist

    1. [Feat #23130] Add custom status settings to profile #23267
    2. https://github.com/Expensify/App/pull/23267/files#r1407485604
    3. N/A
    4. I think this is really minor and a regression test is not needed. However, if there's disagreement, then the steps given in the OP seems to be clear enough.
  22. JmillsExpensify commented on Nov 28, 2023

    @JmillsExpensify
    Contributor

    Thanks @allroundexperts. $375 payment approved based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions