Skip to content

[HOLD for payment 2023-10-25] [$500] iOS - WS Invite - Invite message link does not lead to invite message page #29163

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #25543

Version Number: 1.3.80-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

Pre-requisite: user must be logged in, must have sent the invite message link to any workspace to any conversation.

  1. Go to the conversation you have sent the invite message link.
  2. Tap on the invite message link.

Expected Result:

Invite message page should be displayed.

Actual Result:

Workspace page is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Bug6231498_1696920012998.Sgjo9409_1_.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0142f9bb42ec3d0112
  • Upwork Job ID: 1711668274402217984
  • Last Price Increase: 2023-10-10
  • Automatic offers:
    • dukenv0307 | Contributor | 27158437

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 10, 2023
  2. changed the title [-]iOS - WS Invite - Invite message link does not lead to invite message page[/-] [+][$500] iOS - WS Invite - Invite message link does not lead to invite message page[/+] on Oct 10, 2023
  3. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 10, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 10, 2023
  6. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  8. izarutskaya commented on Oct 10, 2023

    @izarutskaya
    Author

    Not reproduced on Prod. It redirects to browser.

    20231010_121241.mp4
  9. 39 remaining items

  10. melvin-bot commented on Oct 18, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-25. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. melvin-bot commented on Oct 18, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@sobitneupane / @dukenv0307] Determine if we should create a regression test for this bug.
    • [@sobitneupane / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. mallenexpensify commented on Oct 26, 2023

    @mallenexpensify
    Contributor

    Lil confused but ....

    Issue reporter: Applause
    Contributor: @dukenv0307 paid $750 via Upwork, inc. urgency bonus (it looks like it was technically one hour over 3 days)
    Contributor+: @sobitneupane due $750 via NewDot. inc. urgency bonus

    I see regression mentioned above, my assumption is that this issue came from another regression, not that there was one here, please correct me if i'm wrong. Unsure if we want a regression test specifically for this if the issue came from another, what cha think @sobitneupane ?

  13. sobitneupane commented on Oct 30, 2023

    @sobitneupane
    Contributor

    I see regression mentioned above, my assumption is that this issue came from another regression, not that there was one here, please correct me if i'm wrong.

    @mallenexpensify You are right. This issue was regression from #28050. There is no regression from the PR associated with the issue.

  14. sobitneupane commented on Oct 30, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #28050

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #29163 (comment)

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    This issue was caused by some merge conflict during a large refactor.

    • Determine if we should create a regression test for this bug.

    Yes.

    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    #29163 (comment)

  15. sobitneupane commented on Oct 30, 2023

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Go to Settings > Workspaces > Select any workspace
    2. Go to Members > Invite > Invite message page
    3. Copy the URL
    4. Send this to a report
    5. Logout out and login again
    6. Click on the url sent in step 3.
    7. Verify that the user is redirected to invite page appears

    Do we agree 👍 or 👎

  16. sobitneupane commented on Oct 30, 2023

    @sobitneupane
    Contributor

    #29163 (comment)

    Requested payment on newDot.

  17. mallenexpensify commented on Oct 30, 2023

    @mallenexpensify
    Contributor
  18. JmillsExpensify commented on Nov 3, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @sobitneupane based on this summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions