You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-25] [$500] iOS - WS Invite - Invite message link does not lead to invite message page #29163
changed the title [-]iOS - WS Invite - Invite message link does not lead to invite message page[/-][+][$500] iOS - WS Invite - Invite message link does not lead to invite message page[/+]on Oct 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-25. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@sobitneupanedoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Issue reporter: Applause
Contributor: @dukenv0307 paid $750 via Upwork, inc. urgency bonus (it looks like it was technically one hour over 3 days)
Contributor+: @sobitneupane due $750 via NewDot. inc. urgency bonus
I see regression mentioned above, my assumption is that this issue came from another regression, not that there was one here, please correct me if i'm wrong. Unsure if we want a regression test specifically for this if the issue came from another, what cha think @sobitneupane ?
I see regression mentioned above, my assumption is that this issue came from another regression, not that there was one here, please correct me if i'm wrong.
@mallenexpensify You are right. This issue was regression from #28050. There is no regression from the PR associated with the issue.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
This issue was caused by some merge conflict during a large refactor.
Determine if we should create a regression test for this bug.
Yes.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
[-]iOS - WS Invite - Invite message link does not lead to invite message page[/-][+][$500] iOS - WS Invite - Invite message link does not lead to invite message page[/+]melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0142f9bb42ec3d0112
melvin-bot commentedon Oct 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)izarutskaya commentedon Oct 10, 2023
Not reproduced on Prod. It redirects to browser.
20231010_121241.mp4
39 remaining items
melvin-bot commentedon Oct 18, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-25. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 18, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mallenexpensify commentedon Oct 26, 2023
Lil confused but ....
Issue reporter: Applause
Contributor: @dukenv0307 paid $750 via Upwork, inc. urgency bonus (it looks like it was technically one hour over 3 days)
Contributor+: @sobitneupane due $750 via NewDot. inc. urgency bonus
I see regression mentioned above, my assumption is that this issue came from another regression, not that there was one here, please correct me if i'm wrong. Unsure if we want a regression test specifically for this if the issue came from another, what cha think @sobitneupane ?
sobitneupane commentedon Oct 30, 2023
@mallenexpensify You are right. This issue was regression from #28050. There is no regression from the PR associated with the issue.
sobitneupane commentedon Oct 30, 2023
#28050
#29163 (comment)
This issue was caused by some merge conflict during a large refactor.
Yes.
#29163 (comment)
sobitneupane commentedon Oct 30, 2023
Regression Test Proposal
Do we agree 👍 or 👎
sobitneupane commentedon Oct 30, 2023
#29163 (comment)
Requested payment on newDot.
mallenexpensify commentedon Oct 30, 2023
Thanks @sobitneupane ! Regression test GH created
Payment breakdown above is up to date.
JmillsExpensify commentedon Nov 3, 2023
$750 payment approved for @sobitneupane based on this summary.