Skip to content

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Crash when opening uknown profile URL #29313

New issue
New issue
Closed
Closed
[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Crash when opening uknown profile URL#29313
Assignees
stephanieelliotttechievivekaimane-chnaif
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Description

@mountiny
mountiny
opened on Oct 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ginsuma
Slack conversation: #29088 (comment)

Action Performed:

Break down in numbered steps

Case 1:

  1. Open this link in browser: https://staging.new.expensify.com/a/12345678 (http://localhost:8082/a/12345678 for dev)
  2. Verify that app doesn't crash and shows hidden profile page

Case 2: (Follow repro step in #29088)

Precondition: user A and user B should have no prior chat history (only public accounts)

  1. Open a tab where user A is signed in
  2. Click on 'Profile avatar' > Share code > Copy URL to clipboard
  3. Open a tab where user B is signed in
  4. Paste the URL to the address bar
  5. Press enter
  6. Verify that app doesn't crash and profile page shows correctly

Expected Result:

Describe what you think should've happened

No crash

Actual Result:

Describe what actually happened

Crash

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Activity

  1. mountiny
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 11, 2023
  2. mountiny
    assigned
    techievivek
    and
    aimane-chnaif
    on Oct 11, 2023
  3. melvin-bot
    assigned
    stephanieelliott
    on Oct 11, 2023

  4. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    melvin-botBot
    on Oct 11, 2023

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    melvin-botBot
    on Oct 11, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. mountiny
    added
    ReviewingHas a PR in review
    on Oct 11, 2023

  7. mountiny commented on Oct 11, 2023

    @mountiny
    mountiny
    on Oct 11, 2023
    ContributorAuthor

    PR is merged need to cp it

  8. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 11, 2023

  9. OSBotify commented on Oct 11, 2023

    @OSBotify
    OSBotify
    on Oct 11, 2023
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  10. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    melvin-botBot
    on Oct 11, 2023

    Current assignee @techievivek is eligible for the Engineering assigner, not assigning anyone new.

  11. 25 remaining items

  12. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    melvin-botBot
    on Oct 16, 2023

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Oct 20, 2023

  14. melvin-bot commented on Oct 23, 2023

    @melvin-bot
    melvin-botBot
    on Oct 23, 2023

    @stephanieelliott, @techievivek, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. stephanieelliott commented on Oct 25, 2023

    @stephanieelliott
    stephanieelliott
    on Oct 25, 2023
    Contributor

    Summarizing payment on this issue:

    • Issue reporter: $50 @ginsuma (pay via Upwork)
    • Contributor: N/A [internal]
    • Contributor+: $500 @aimane-chnaif (pay via Upwork)

    Upwork job is here, not eligible for bonus

  16. melvin-bot
    removed
    Overdue
    on Oct 25, 2023

  17. stephanieelliott commented on Oct 25, 2023

    @stephanieelliott
    stephanieelliott
    on Oct 25, 2023
    Contributor

    @ginsuma can you please share your Upwork profile? I'm not able to find you there.

    @aimane-chnaif I've sent you the offer!

  18. melvin-bot
    added
    Overdue
    on Oct 30, 2023

  19. techievivek commented on Oct 30, 2023

    @techievivek
    techievivek
    on Oct 30, 2023
    Contributor

    Not overdue, we are finishing up the payment.

  20. melvin-bot
    removed
    Overdue
    on Oct 30, 2023

  21. stephanieelliott commented on Oct 31, 2023

    @stephanieelliott
    stephanieelliott
    on Oct 31, 2023
    Contributor

    @ginsuma can you please share your Upwork profile? I'm not able to find you there.

    Bump @ginsuma

  22. ginsuma commented on Nov 1, 2023

    @ginsuma
    ginsuma
    on Nov 1, 2023
    Contributor

    @ginsuma can you please share your Upwork profile? I'm not able to find you there.

    @stephanieelliott, I already accepted your offer https://www.upwork.com/nx/wm/offer/27385226.

  23. stephanieelliott commented on Nov 1, 2023

    @stephanieelliott
    stephanieelliott
    on Nov 1, 2023
    Contributor

    All paid!

  24. stephanieelliott
    closed this as completedon Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions