[$100] Group chat - No tooltip when hovering over group member avatar in details page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.81-4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to any group chat
Click on the group chat header
Hover over the avatars in group details page

Expected Result:

Tooltip appears when hovering over group member avatar

Actual Result:

Tooltip does not appear when hovering over group member avatar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6233110_1697032667398.20231011_201711.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01939a661b5c2c58a4
Upwork Job ID: 1712149389829230592
Last Price Increase: 2023-10-11

@NicMendonca

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@joelbettner

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I am available right now and can raise quick PR if needed

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip is not working in group details page avatars

What is the root cause of that problem?

In RoomHeaderAvatar component, avatars are not wrapped in tooltip

App/src/components/RoomHeaderAvatars.js

Lines 90 to 98 in 907e65e

    
           <Avatar 
        
               source={icon.source} 
        
               fill={themeColors.iconSuccessFill} 
        
               size={CONST.AVATAR_SIZE.LARGE} 
        
               containerStyles={[...iconStyle, StyleUtils.getAvatarBorderRadius(CONST.AVATAR_SIZE.LARGE_BORDERED, icon.type)]} 
        
               name={icon.name} 
        
               type={icon.type} 
        
               fallbackIcon={icon.fallbackIcon} 
        
           />

What changes do you think we should make in order to solve the problem?

We should wrap avatar components in UserDetailsTooltip, like this:

 <UserDetailsTooltip
                                        key={`stackedAvatars-${index}`}
                                        accountID={icon.id}
                                        icon={icon}
                                        fallbackUserDetails={{
                                            displayName: icon.name,
                                            avatar: icon.avatar,
                                        }}
                                    >
                                        <View>
                                    <Avatar
                                        source={icon.source}
                                        fill={themeColors.iconSuccessFill}
                                        size={CONST.AVATAR_SIZE.LARGE}
                                        containerStyles={[...iconStyle, StyleUtils.getAvatarBorderRadius(CONST.AVATAR_SIZE.LARGE_BORDERED, icon.type)]}
                                        name={icon.name}
                                        type={icon.type}
                                        fallbackIcon={icon.fallbackIcon}
                                    /></View>
                                        </UserDetailsTooltip>

What alternative solutions did you explore? (Optional)

This is not a deploy blocker. On production, when clicking the header we get shown the following:

On staging, those details are now under the "Members" selection:

Under the "Members" selection everything works correctly with the tooltip:

I think we want to show the tooltip as we do everywhere for consistency but I agree this is not a blocker, we could export this for $250

Job added to Upwork: https://www.upwork.com/jobs/~01939a661b5c2c58a4

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

Upwork job price has been updated to $100

I think we want to show the tooltip as we do everywhere for consistency but I agree this is not a blocker, we could export this for $250

Huh? What's the issue here? We don't show a tooltip when you hover over a user avatar in the profile page, why do we need to do it here in the group details page? A tooltip on hover over the name is enough IMO.

I am going to close this because this is expected behaviour. Please re-open the issue or bring a discussion in Slack if you disagree.

Alright, we used to show the tooltip almost everywhere so if these are the exception, thats fine

Navigation Menu

Repository navigation

[$100] Group chat - No tooltip when hovering over group member avatar in details page #29322

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

5 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Avatar
	source={icon.source}
	fill={themeColors.iconSuccessFill}
	size={CONST.AVATAR_SIZE.LARGE}
	containerStyles={[...iconStyle, StyleUtils.getAvatarBorderRadius(CONST.AVATAR_SIZE.LARGE_BORDERED, icon.type)]}
	name={icon.name}
	type={icon.type}
	fallbackIcon={icon.fallbackIcon}
	/>

[$100] Group chat - No tooltip when hovering over group member avatar in details page #29322

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

alitoshmatov commented on Oct 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

joelbettner commented on Oct 11, 2023

5 remaining items

mountiny commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

trjExpensify commented on Oct 11, 2023

techievivek commented on Oct 13, 2023

mountiny commented on Oct 15, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions