[HOLD for payment 2023-11-09] [$500] IOU - Site crashes when editing a description with numbers after changing amount

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.81-4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/ in Chrome or Android App
Click the Green '+' Icon in the LHN
Choose "Request Money"
Enter an Amount
Tap Next
Choose a Recipient
Tap "Request"
Tap on the IOU transaction to open IOU detail page
Enter a description with numbers only (ex 444) and save it
Tap the amount and change it
Tap the Description again

Expected Result:

When user changes Amount and taps Description, the site must not crash

Actual Result:

When user changes Amount and tap Description, the site crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6233354_1697045658598.77cras.mp4

logs.txt

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01651ddb346bd06cdb
Upwork Job ID: 1716876781919485952
Last Price Increase: 2023-10-24

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@puneetlath

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I just attempted this on staging and it didn't crash.

Reviewing label has been removed, please complete the "BugZero Checklist".

@burczu

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

description/comment to string #30526

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@burczu does not require payment (Contractor)
@Jenemark requires payment

@burczu

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@burczu] The PR that introduced the bug has been identified. Link to the PR:
[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@burczu

Payment is upcoming. Here's what I understand:

Issue Reporter: NA - Applause Team
Contributor: $500 @burczu (contractor so not paid through Upwork/New Expensify)
Contributor+: $500 @Jenemark (Paid through Upwork)

Eligible for 50% #urgency bonus? UPDATED: No - the PR was created Oct 27 which is after our Oct 24th announcement about removing speed bonuses

Upwork job is here.

Let me know if any of this needs to change and a regression test when you have a moment @burczu

@Jenemark

@Jenemark can you accept my Upwork offer? Thanks for submitting the proposal in Upwork!
@burczu can you let us know about a regression test?

@Christinadobrzyn

@Christinadobrzyn I accepted it on upwork, thank you :-)

@Jenemark

Awesome! Thanks @Jenemark - I paid you in Upwork.

@burczu can you let us know about a regression test?

@burczu

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@burczu] The PR that introduced the bug has been identified. Link to the PR:

I don't think it's a regression - this was done like this from the beginning.

[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

n/a

[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

n/a

[@burczu] Determine if we should create a regression test for this bug.

I don't think we need to add regression test here - this is quite uncommon case, so I think not very impactful. Also the test would have quite a lot of steps.

[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@burczu

thanks @burczu!

I think this is good to close, please let me know if I'm missing anything!

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-09] [$500] IOU - Site crashes when editing a description with numbers after changing amount #29369

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

41 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-11-09] [$500] IOU - Site crashes when editing a description with numbers after changing amount #29369

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

puneetlath commented on Oct 11, 2023

41 remaining items

melvin-bot commented on Nov 2, 2023

melvin-bot commented on Nov 2, 2023

melvin-bot commented on Nov 2, 2023

Christinadobrzyn commented on Nov 8, 2023

Christinadobrzyn commented on Nov 10, 2023

Jenemark commented on Nov 11, 2023

Christinadobrzyn commented on Nov 13, 2023

burczu commented on Nov 14, 2023

Christinadobrzyn commented on Nov 14, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions