Skip to content

[HOLD for payment 2023-10-23] Distance - The merchant is displayed on the distance request page but not on the request report #29374

New issue
New issue
Closed
Closed
[HOLD for payment 2023-10-23] Distance - The merchant is displayed on the distance request page but not on the request report#29374
Assignees
francoislntdiarymallenexpensify
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Description

@kbecciv
kbecciv
opened on Oct 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.81.5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jo-ui
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697045740106739

Action Performed:

  1. Open request money
  2. Change tab to distance
  3. Enter start and finish location
  4. Select workspace
  5. Notice the merchant value is shown
  6. Send the request
  7. Open the request

Expected Result:

Merchant value should not be shown on the distance page or it should also be visible on the request report page

Actual Result:

The Merchant value is displayed on distance request page but not on the request report page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
20231011_214209.mp4
Android: mWeb Chrome
20231011_213559.mp4
iOS: Native

Screenshot_20231011-221159

iOS: mWeb Safari

Screenshot_20231011-221313

MacOS: Chrome / Safari
2023-10-11.21-31-06.mp4
Recording.4959.mp4
MacOS: Desktop
merchant.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019f6b2700f396ce6a
  • Upwork Job ID: 1712195602319327232
  • Last Price Increase: 2023-10-11

Activity

  1. kbecciv
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 11, 2023
  2. melvin-bot
    changed the title [-]Distance - The merchant is displayed on the distance request page but not on the request report[/-] [+][$500] Distance - The merchant is displayed on the distance request page but not on the request report[/+] on Oct 11, 2023
  3. melvin-bot
    assigned
    mallenexpensify
    on Oct 11, 2023

  4. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    melvin-botBot
    on Oct 11, 2023

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    melvin-botBot
    on Oct 11, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~019f6b2700f396ce6a

  6. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 11, 2023

  7. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    melvin-botBot
    on Oct 11, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. melvin-bot
    assigned
    ntdiary
    on Oct 11, 2023

  9. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    melvin-botBot
    on Oct 11, 2023

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

  10. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 11, 2023

  11. 41 remaining items

  12. melvin-bot
    changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Distance - The merchant is displayed on the distance request page but not on the request report[/-] [+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Distance - The merchant is displayed on the distance request page but not on the request report[/+] on Oct 16, 2023

  13. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    melvin-botBot
    on Oct 16, 2023

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty

  14. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    melvin-botBot
    on Oct 16, 2023

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
    • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ntdiary] Determine if we should create a regression test for this bug.
    • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Oct 20, 2023

  16. melvin-bot commented on Oct 23, 2023

    @melvin-bot
    melvin-botBot
    on Oct 23, 2023

    @francoisl, @ntdiary, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. mallenexpensify
    changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Distance - The merchant is displayed on the distance request page but not on the request report[/-] [+][HOLD for payment 2023-10-23] Distance - The merchant is displayed on the distance request page but not on the request report[/+] on Oct 23, 2023

  18. mallenexpensify commented on Oct 23, 2023

    @mallenexpensify
    mallenexpensify
    on Oct 23, 2023
    Contributor

    Issue reporter: @jo-ui paid $50 via Upwork
    Contributor: N/A
    Contributor+: @ntdiary paid $500 via Upwork.

    @jo-ui and @ntdiary , can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~019f6b2700f396ce6a

    Also... @jo-ui, nice suit in your profile pic!

  19. melvin-bot
    removed
    Overdue
    on Oct 23, 2023

  20. ntdiary commented on Oct 24, 2023

    @ntdiary
    ntdiary
    on Oct 24, 2023
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    We have related check item in the review list, I guess it's just that the linked PR is relatively large, so this detail was accidentally overlooked

    • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)

  21. ntdiary commented on Oct 24, 2023

    @ntdiary
    ntdiary
    on Oct 24, 2023
    Contributor

    Issue reporter: @jo-ui due $50 via Upwork Contributor: N/A Contributor+: @ntdiary due $500 via Upwork.

    @jo-ui and @ntdiary , can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~019f6b2700f396ce6a

    Also... @jo-ui, nice suit in your profile pic!

    @mallenexpensify, thank you! Have accepted. : )

  22. jo-ui commented on Oct 24, 2023

    @jo-ui
    jo-ui
    on Oct 24, 2023

    Issue reporter: @jo-ui due $50 via Upwork
    Contributor: N/A
    Contributor+: @ntdiary due $500 via Upwork.

    @jo-ui and @ntdiary , can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~019f6b2700f396ce6a

    Also... @jo-ui, nice suit in your profile pic!

    @mallenexpensify thank you, I've accepted the offer on upwork

  23. mallenexpensify commented on Oct 24, 2023

    @mallenexpensify
    mallenexpensify
    on Oct 24, 2023
    Contributor

    Thanks @ntdiary and @jo-ui , you've both been paid, updated the comment above has been updated to show payment

  24. mallenexpensify
    closed this as completedon Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions