Send money - Date is not saved when sending money

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.81-6

Reproducible in staging?: Yes

Reproducible in production?: No. Send money is not available on prod

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to FAB > Send money
Enter amount > Next
Select user > Next
Change the date and send the money
Open Send money details page

Expected Result:

The new date is saved

Actual Result:

The new date is not saved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6233520_1697053849661.20231012_005528.mp4

MacOS: Desktop

View all open jobs on GitHub

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@deetergp

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

This is not a blocker, its known and it will be fixed with this PR which will hide the date, you cannot edit the date oon send money request. Same goes for merchant. #29358

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send money - Date is not saved when sending money

What is the root cause of that problem?

In SendMoneyElsewhere API, we don't send created params to server and in Optimistic Transaction we also don't add created field

App/src/libs/actions/IOU.js

Line 2171 in 6f533d6

    
           const optimisticTransaction = TransactionUtils.buildOptimisticTransaction(amount, currency, optimisticIOUReport.reportID, comment);

What changes do you think we should make in order to solve the problem?

First we should add created field to Optimistic Transaction when sendMoney. Do that will resolve this issue from FE. But It doesn't update created field in Server. To update created in Server we need to:

We should send created params (date field) to server
From BE, When call SendMoneyElsewhere API, We need to update created field in the transaction

What alternative solutions did you explore? (Optional)

This can be closed, nobody to be paid

Navigation Menu

Repository navigation

Send money - Date is not saved when sending money #29381

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Send money - Date is not saved when sending money #29381

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Oct 11, 2023

melvin-bot commented on Oct 11, 2023

mountiny commented on Oct 11, 2023

DylanDylann commented on Oct 12, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mountiny commented on Oct 12, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions