Repository navigation
[$500] Deeplinking to distantce request money allows requesting 0 amount #29401
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.81-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @lidiyakelay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696946373513129
Action Performed:
- go to + FAB
- Click on request money
- click on distance tab
- go to the url 'https://staging.new.expensify.com/request/new/distance' change distance to 'participants'
Expected Result:
the url redirects back
Actual Result:
url goes to participants allowing user to request 0 amount
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Android: Native
Android: mWeb Chrome
4_5852834878667624402.mp4
iOS: Native
iOS: mWeb Safari
4_5852491904054202624.MP4
MacOS: Chrome / Safari
participants.mp4
MacOS: Desktop
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01b1f3e4d9495c91ca
- Upwork Job ID: 1712257041055375360
- Last Price Increase: 2023-10-12
Activity
melvin-bot commentedon Oct 12, 2023
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]Deeplinking to distantce request money allows requesting 0 amount[/-][+][$500] Deeplinking to distantce request money allows requesting 0 amount[/+]melvin-bot commentedon Oct 12, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01b1f3e4d9495c91ca
melvin-bot commentedon Oct 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 12, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)graylewis commentedon Oct 12, 2023
This seems related to this ongoing refactor: #26538.
There's a pretty clear fix here: check if there are defined waypoints in the request and trigger goBack if there isn't. This was already attempted here: #27826
It failed because the waypoints weren't defined in the first frame. This could probably be fixed with a well-defined dependency array in useEffect.
If it's still deemed worthwhile to attempt another patch while the refactor is ongoing, I'd be happy to write a proper proposal @maddylewis
DylanDylann commentedon Oct 12, 2023
This issue will be resolved after my PR is merged. We should hold this issue
[-][$500] Deeplinking to distantce request money allows requesting 0 amount[/-][+][HOLD] [$500] Deeplinking to distantce request money allows requesting 0 amount[/+]5 remaining items
[-][HOLD] [$500] Deeplinking to distantce request money allows requesting 0 amount[/-][+][$500] Deeplinking to distantce request money allows requesting 0 amount[/+]maddylewis commentedon Nov 9, 2023
looks like this has since merged - #28308
@mollfpr - when you have a chance, could you confirm if this bug is still reproducible? ty!
DylanDylann commentedon Nov 9, 2023
This issue is resolved. Let's close
melvin-bot commentedon Nov 9, 2023
@mollfpr @maddylewis this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:
Thanks!
melvin-bot commentedon Nov 9, 2023
Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.
mollfpr commentedon Nov 9, 2023
I confirmed this issue is solved.
Screen.Recording.2023-11-09.at.21.36.44.mp4
We can close the issue now.